-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Fix broken links #7900
docs: Fix broken links #7900
Conversation
Nick Ilieskou seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
73ff65a
to
7f485a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! much appreciated just one small comment
docs/docs/target/vm.md
Outdated
@@ -234,7 +234,7 @@ Reference: [VMware Virtual Disk Format 1.1.pdf][vmdk] | |||
| ZFS | | | |||
|
|||
|
|||
[vmdk]: https://www.vmware.com/app/vmdk/?src=vmdk | |||
[vmdk]: https://docs.vmware.com/en |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The usage of this link in L215 is supposed to get to the VMware Virtual Disk Format 1.1.pdf
file. It seems the Broadcom has taken down VMDK specification documents (I couldn't find anything online).
Changing the link to the documentation homepage won't help.
I suggest perhaps linking to an unofficial specification, like: https://github.com/libyal/libvmdk/blob/main/documentation/VMWare%20Virtual%20Disk%20Format%20(VMDK).asciidoc or alternatively removing the link.
@itaysk Thanks for the quick review. Very much appreciate it. I did the rework. Could you please take another look? |
It's conflicting now. |
Description
Related issues
Checklist