Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix broken links #7900

Merged
merged 4 commits into from
Nov 18, 2024
Merged

Conversation

nick1989Gr
Copy link
Contributor

Description

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nick1989Gr nick1989Gr requested a review from knqyf263 as a code owner November 11, 2024 11:15
@CLAassistant
Copy link

CLAassistant commented Nov 11, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Nick Ilieskou seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@nick1989Gr nick1989Gr changed the title Draft: docs: Fix broken links docs: Fix broken links Nov 11, 2024
Copy link
Contributor

@itaysk itaysk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! much appreciated just one small comment

@@ -234,7 +234,7 @@ Reference: [VMware Virtual Disk Format 1.1.pdf][vmdk]
| ZFS | |


[vmdk]: https://www.vmware.com/app/vmdk/?src=vmdk
[vmdk]: https://docs.vmware.com/en
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The usage of this link in L215 is supposed to get to the VMware Virtual Disk Format 1.1.pdf file. It seems the Broadcom has taken down VMDK specification documents (I couldn't find anything online).
Changing the link to the documentation homepage won't help.
I suggest perhaps linking to an unofficial specification, like: https://github.com/libyal/libvmdk/blob/main/documentation/VMWare%20Virtual%20Disk%20Format%20(VMDK).asciidoc or alternatively removing the link.

@nick1989Gr
Copy link
Contributor Author

nick1989Gr commented Nov 12, 2024

@itaysk Thanks for the quick review. Very much appreciate it. I did the rework. Could you please take another look?

@nick1989Gr nick1989Gr requested a review from itaysk November 12, 2024 08:21
@knqyf263
Copy link
Collaborator

It's conflicting now.

@knqyf263 knqyf263 added this pull request to the merge queue Nov 18, 2024
Merged via the queue into aquasecurity:main with commit afd7216 Nov 18, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: fix broken links
4 participants