refactor: SUSE - update OSType constants and references for compatibi…

[santhosh1729]

1. Renamed deprecated SUE OSType constants to maintain backward compatibility.
2. Modified all occurrences where the old constants were used to ensure consistency

[knqyf263]

Can we just replace the legacy names with the new names in a single place? For example:

diff --git a/pkg/fanal/types/artifact.go b/pkg/fanal/types/artifact.go
index b25aaa954..18f026653 100644
--- a/pkg/fanal/types/artifact.go
+++ b/pkg/fanal/types/artifact.go
@@ -45,6 +45,14 @@ func (o *OS) Merge(newOS OS) {
                        o.Extended = true
                }
        }
+       o.Normalize()
+}
+
+// Normalize normalizes OS family names for backward compatibility
+func (o *OS) Normalize() {
+       if alias, ok := OSTypeAliases[o.Family]; ok {
+               o.Family = alias
+       }
 }

 type Repository struct {
diff --git a/pkg/fanal/types/const.go b/pkg/fanal/types/const.go
index 42f248ba1..2e07709ad 100644
--- a/pkg/fanal/types/const.go
+++ b/pkg/fanal/types/const.go
@@ -41,14 +41,17 @@ const (
        SLES               OSType = "sles"
        Ubuntu             OSType = "ubuntu"
        Wolfi              OSType = "wolfi"
-
-       // These below constants are retained for backward compatibility with older versions of Aqua
-       OpenSUSELeapLegacy       OSType = "opensuse.leap"
-       OpenSUSETumbleweedLegacy OSType = "opensuse.tumbleweed"
-       SLEMicroLegacy           OSType = "suse linux enterprise micro"
-       SLESLegacy               OSType = "suse linux enterprise server"
 )

+// OSTypeAliases is a map of aliases for operating systems.
+// This is used to map the old family names to the new ones for backward compatibility.
+var OSTypeAliases = map[OSType]OSType{
+       "opensuse.leap":                OpenSUSELeap,
+       "opensuse.tumbleweed":          OpenSUSETumbleweed,
+       "suse linux enterprise micro":  SLEMicro,
+       "suse linux enterprise server": SLES,
+}
+
 // Programming language dependencies
 const (
        Bundler        LangType = "bundler"

[santhosh1729]

Can we just replace the legacy names with the new names in a single place? For example:

diff --git a/pkg/fanal/types/artifact.go b/pkg/fanal/types/artifact.go
index b25aaa954..18f026653 100644
--- a/pkg/fanal/types/artifact.go
+++ b/pkg/fanal/types/artifact.go
@@ -45,6 +45,14 @@ func (o *OS) Merge(newOS OS) {
                        o.Extended = true
                }
        }
+       o.Normalize()
+}
+
+// Normalize normalizes OS family names for backward compatibility
+func (o *OS) Normalize() {
+       if alias, ok := OSTypeAliases[o.Family]; ok {
+               o.Family = alias
+       }
 }

 type Repository struct {
diff --git a/pkg/fanal/types/const.go b/pkg/fanal/types/const.go
index 42f248ba1..2e07709ad 100644
--- a/pkg/fanal/types/const.go
+++ b/pkg/fanal/types/const.go
@@ -41,14 +41,17 @@ const (
        SLES               OSType = "sles"
        Ubuntu             OSType = "ubuntu"
        Wolfi              OSType = "wolfi"
-
-       // These below constants are retained for backward compatibility with older versions of Aqua
-       OpenSUSELeapLegacy       OSType = "opensuse.leap"
-       OpenSUSETumbleweedLegacy OSType = "opensuse.tumbleweed"
-       SLEMicroLegacy           OSType = "suse linux enterprise micro"
-       SLESLegacy               OSType = "suse linux enterprise server"
 )

+// OSTypeAliases is a map of aliases for operating systems.
+// This is used to map the old family names to the new ones for backward compatibility.
+var OSTypeAliases = map[OSType]OSType{
+       "opensuse.leap":                OpenSUSELeap,
+       "opensuse.tumbleweed":          OpenSUSETumbleweed,
+       "suse linux enterprise micro":  SLEMicro,
+       "suse linux enterprise server": SLES,
+}
+
 // Programming language dependencies
 const (
        Bundler        LangType = "bundler"

[santhosh1729]

@knqyf263 I have updated the pr with suggested changes, Thank you!!

[knqyf263]

The logic looks good, but we need to add a test.

[santhosh1729]

The logic looks good, but we need to add a test.

Sure, I will add it. Thank you!!

[santhosh1729]

The logic looks good, but we need to add a test.

@knqyf263 I have added test for the change, can you please review it once?

[knqyf263]

Left a small comment. The rest looks good.

[knqyf263]

nit: Other cases are lowercase.

Suggested change

	name: "SUSE Images - Legacy OS Name with Backward Compatibility",
	name: "SUSE images - legacy OS name with backward compatibility",

[santhosh1729]

@knqyf263 I have updated the Test Name as suggested, Thank you!!

[knqyf263]

@DmitriyLewen Would you also take a look?