Filters support

[galaxyse]

No description provided.

[cla-bot]

Fresh avocado detected! Welcome and thank you for your contribution @galaxyse. My avocado-loving overlords have decreed a signed CLA is required for PRs. Please see https://github.com/arangodb/arangodb/blob/devel/CONTRIBUTING.md file to learn more or ask @cw00dw0rd if you have issues.

[joerg84]

I suppose this should be changed according to CLA

[rashtao]

Hi @galaxyse , thanks for your contribution!

Unfortunately this PR has compilation errors (see https://github.com/arangodb/spring-data/actions/runs/5867038721).

From a first look, I do not fully understand the feature(s) you are trying to implement, since I cannot see any integration test, but just unit tests. I.e. it would be useful having some tests where the new annotations introduced in this PR are used. A description of the feature in the PR would be also appreciated and help updating the official documentation web pages.

Furthermore, I can only see few operators (AND and OR) and comparators (==) implemented. Is this PR still a work in progress?

From a features standpoint, some Spring Data modules already implement capabilities to apply query filters, such as:

• Query By Example (https://docs.spring.io/spring-data/commons/docs/current/reference/html/#query-by-example)
• Querydsl (https://docs.spring.io/spring-data/commons/docs/current/reference/html/#core.extensions.querydsl)
• JPA Criteria API (https://docs.spring.io/spring-data/jpa/docs/current/reference/html/#specifications)

Are any of these suitable for your needs?

Ideally, this library can be enhanced with support to any of the API mentioned above, thus avoiding implementing a new API specific for ArangoDB. Execution can be then customized, to implement specific AQL.

Best Regards

[galaxyse]

Hi @galaxyse , thanks for your contribution!

Unfortunately this PR has compilation errors (see https://github.com/arangodb/spring-data/actions/runs/5867038721).

From a first look, I do not fully understand the feature(s) you are trying to implement, since I cannot see any integration test, but just unit tests. I.e. it would be useful having some tests where the new annotations introduced in this PR are used. A description of the feature in the PR would be also appreciated and help updating the official documentation web pages.

Furthermore, I can only see few operators (AND and OR) and comparators (==) implemented. Is this PR still a work in progress?

From a features standpoint, some Spring Data modules already implement capabilities to apply query filters, such as:

• Query By Example (https://docs.spring.io/spring-data/commons/docs/current/reference/html/#query-by-example)
• Querydsl (https://docs.spring.io/spring-data/commons/docs/current/reference/html/#core.extensions.querydsl)
• JPA Criteria API (https://docs.spring.io/spring-data/jpa/docs/current/reference/html/#specifications)

Are any of these suitable for your needs?

Ideally, this library can be enhanced with support to any of the API mentioned above, thus avoiding implementing a new API specific for ArangoDB. Execution can be then customized, to implement specific AQL.

Best Regards

Thank you for the review and response. The provided links doesn't support out needs. We need keyword based search and filtering. I have fixed the compilation issue. Can you check ?