Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router issues #510

Open
4 tasks
Danziger opened this issue Oct 21, 2024 · 0 comments
Open
4 tasks

Router issues #510

Danziger opened this issue Oct 21, 2024 · 0 comments

Comments

@Danziger
Copy link
Contributor

Danziger commented Oct 21, 2024

  • Router will check all routes, even if a match has already been found.
  • Router will not take into account route specificity, so /foo/:param and /foo/new both match at the same time.
  • Route params should be accessed directly from the consumer component using a hook. There should be no need for the Route component to accept a function as children.
  • A config-driven router with configurable guard logic, param validation and lazy loading would be good and speed things up, particularly in the embedded wallet.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant