Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Why change to non-exhaustive language model? #116

Open
alexipeck opened this issue Aug 22, 2024 · 2 comments
Open

Question: Why change to non-exhaustive language model? #116

alexipeck opened this issue Aug 22, 2024 · 2 comments
Labels

Comments

@alexipeck
Copy link

Why move from whoami::lang() which returned a Vec to whoami::langs() which returns Vec if the enum Language isn't using close to an exhaustive list? Having only English, Spanish and __ to represent other's seems like it would further complicate language matching downstream.

@AldaronLau
Copy link
Member

The plan is to eventually make the enum include all ISO 639-1 language codes, but has not been prioritized

@AldaronLau
Copy link
Member

It is just an internal detail at the moment, usage should be fine using .to_string() for any language / country combination

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants