Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed fork of https://github.com/closedcube/ClosedCube_SHT31D_Arduino #5850

Merged
merged 2 commits into from
Jan 30, 2025
Merged

fixed fork of https://github.com/closedcube/ClosedCube_SHT31D_Arduino #5850

merged 2 commits into from
Jan 30, 2025

Conversation

malarz-supla
Copy link
Contributor

https://github.com/closedcube/ is dead

I found and fix error in this library.
I worked on other fork of library, which had the same code as 1.5.1 installed from Arduino

@malarz-supla
Update repositories.txt
7846d7c 
https://github.com/closedcube/ is dead

I found and fix error in this library. 
I worked on other fork of library.
@malarz-supla
Update repositories.txt
a4b09a9 
added fork of dead
https://github.com/closedcube/ClosedCube_SHT31D_Arduino
@github-actions github-actions bot added the topic: submission Add library to the list label Jan 29, 2025
@github-actions GitHub Actions
Copy link
Contributor

❌ ERROR: Arduino Lint found errors with https://github.com/malarz-supla/ClosedCube_SHT31D_Arduino:

Linting library in ClosedCube_SHT31D_Arduino
INFO: No header file found matching library name (ClosedCube_SHT31D__fork_.h). Best practices are for primary header    
      filename to match library name.                                                                                   
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
ERROR: Prohibited character(s) in library.properties name value: ClosedCube SHT31D (fork)                    
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP011)                                                                                          
WARNING: library.properties name ClosedCube SHT31D (fork) contains spaces. Although supported, best practices is to not 
         use spaces.                                                                                                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   

Linter results for project: 1 ERRORS, 1 WARNINGS

-------------------

Linting sketch in ClosedCube_SHT31D_Arduino/examples/periodicmode

Linter results for project: no errors or warnings

-------------------

Linting sketch in ClosedCube_SHT31D_Arduino/examples/reset

Linter results for project: no errors or warnings

-------------------

Linting sketch in ClosedCube_SHT31D_Arduino/examples/singleshotmode

Linter results for project: no errors or warnings

-------------------

Linting sketch in ClosedCube_SHT31D_Arduino/examples/whoiam

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 1 WARNINGS

@github-actions GitHub Actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @malarz-supla
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

❗ NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@malarz-supla
Copy link
Contributor Author

malarz-supla commented Jan 30, 2025 •
edited
Loading

@ArduinoBot library name fixed

@github-actions GitHub Actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions github-actions bot requested a review from per1234 January 30, 2025 07:29
@github-actions GitHub Actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions github-actions bot removed the request for review from per1234 January 30, 2025 07:29
@github-actions GitHub Actions
Copy link
Contributor

❌ ERROR: Arduino Lint found errors with https://github.com/malarz-supla/ClosedCube_SHT31D_Arduino:

Linting library in ClosedCube_SHT31D_Arduino
INFO: No header file found matching library name (ClosedCube_SHT31D__fork_.h). Best practices are for primary header    
      filename to match library name.                                                                                   
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
ERROR: Prohibited character(s) in library.properties name value: ClosedCube SHT31D (fork)                    
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP011)                                                                                          
WARNING: library.properties name ClosedCube SHT31D (fork) contains spaces. Although supported, best practices is to not 
         use spaces.                                                                                                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   

Linter results for project: 1 ERRORS, 1 WARNINGS

-------------------

Linting sketch in ClosedCube_SHT31D_Arduino/examples/periodicmode

Linter results for project: no errors or warnings

-------------------

Linting sketch in ClosedCube_SHT31D_Arduino/examples/reset

Linter results for project: no errors or warnings

-------------------

Linting sketch in ClosedCube_SHT31D_Arduino/examples/singleshotmode

Linter results for project: no errors or warnings

-------------------

Linting sketch in ClosedCube_SHT31D_Arduino/examples/whoiam

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 1 WARNINGS

@github-actions GitHub Actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @malarz-supla
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

❗ NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@malarz-supla
Copy link
Contributor Author

please close this request

@malarz-supla malarz-supla mentioned this pull request Jan 30, 2025
Closed
per1234
per1234 reviewed Jan 30, 2025
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @malarz-supla . I see you have fixed the error reported by the bot. However, Library Manager works exclusively from Git tags, so the bot won't be able to see the fix you made until you create a new release or tag in the library repository.

If you look at the repository contents at the latest tag, you can see that the version the bot is checking still has the problem:

https://github.com/malarz-supla/ClosedCube_SHT31D_Arduino/blob/v1.5.2/library.properties#L1

name=ClosedCube SHT31D (fork)

❗ Remember to update the version field in the library's library.properties file as needed before making a release/tag.

Once you have done that, simply mention @ArduinoBot in a comment here to trigger it to run the automated checks again. After those are passing, your library will be automatically added to Library Manager.

If you have any questions or concerns, please let me know.

Regards, Per

@per1234 per1234 added the status: waiting for information More information must be provided before work can proceed label Jan 30, 2025
@malarz-supla
Copy link
Contributor Author

@ArduinoBot

@github-actions GitHub Actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions github-actions bot removed the status: waiting for information More information must be provided before work can proceed label Jan 30, 2025
@github-actions GitHub Actions
Copy link
Contributor

❌ ERROR: Arduino Lint found errors with https://github.com/malarz-supla/ClosedCube_SHT31D_Arduino:

Linting library in ClosedCube_SHT31D_Arduino
INFO: No header file found matching library name (ClosedCube_SHT31D_fork.h). Best practices are for primary header      
      filename to match library name.                                                                                   
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name ClosedCube SHT31D fork contains spaces. Although supported, best practices is to not   
         use spaces.                                                                                                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   
ERROR: library.properties version value 1.5.2a is invalid.                                                   
       See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format
       (Rule LP020)                                                                                          
WARNING: library.properties version value 1.5.2a is not compliant with the semver specification.
         See: https://semver.org/                                                               
         (Rule LP021)                                                                           

Linter results for project: 1 ERRORS, 2 WARNINGS

-------------------

Linting sketch in ClosedCube_SHT31D_Arduino/examples/periodicmode

Linter results for project: no errors or warnings

-------------------

Linting sketch in ClosedCube_SHT31D_Arduino/examples/reset

Linter results for project: no errors or warnings

-------------------

Linting sketch in ClosedCube_SHT31D_Arduino/examples/singleshotmode

Linter results for project: no errors or warnings

-------------------

Linting sketch in ClosedCube_SHT31D_Arduino/examples/whoiam

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 1 ERRORS, 2 WARNINGS

@github-actions GitHub Actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @malarz-supla
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

❗ NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@malarz-supla
Copy link
Contributor Author

@ArduinoBot

@github-actions GitHub Actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions GitHub Actions
Copy link
Contributor

A problem was found with your submission https://github.com/malarz-supla/ClosedCube_SHT31D_Arduino

❌ ERROR: The repository has no tags. You need to create a release or tag that matches the version value in the library's library.properties file.

@github-actions GitHub Actions
Copy link
Contributor

Thanks for your interest in contributing to the Arduino Library Manager index @malarz-supla
Please resolve the error(s) mentioned in the previous comment.

After resolving the issue, trigger this check again by doing one of the following:

  • Commit the required change to the branch you submitted this pull request from.
  • Comment here, mentioning @ArduinoBot in the comment.

❗ NOTE: It is not necessary to open a new pull request. ❗

More information:
https://github.com/arduino/library-registry/blob/main/README.md#if-the-problem-is-with-the-pull-request

@malarz-supla
Copy link
Contributor Author

@ArduinoBot

@github-actions GitHub Actions
Copy link
Contributor

Hello! I'm checking your submission again.

@github-actions GitHub Actions
Copy link
Contributor

Arduino Lint has suggestions for possible improvements to https://github.com/malarz-supla/ClosedCube_SHT31D_Arduino:

Linting library in ClosedCube_SHT31D_Arduino
INFO: No header file found matching library name (ClosedCube_SHT31D_fork.h). Best practices are for primary header      
      filename to match library name.                                                                                   
      See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format            
      (Rule LS008)                                                                                                      
WARNING: library.properties name ClosedCube SHT31D fork contains spaces. Although supported, best practices is to not   
         use spaces.                                                                                                    
         See: https://arduino.github.io/arduino-cli/latest/library-specification/#libraryproperties-file-format         
         (Rule LP015)                                                                                                   

Linter results for project: 0 ERRORS, 1 WARNINGS

-------------------

Linting sketch in ClosedCube_SHT31D_Arduino/examples/periodicmode

Linter results for project: no errors or warnings

-------------------

Linting sketch in ClosedCube_SHT31D_Arduino/examples/reset

Linter results for project: no errors or warnings

-------------------

Linting sketch in ClosedCube_SHT31D_Arduino/examples/singleshotmode

Linter results for project: no errors or warnings

-------------------

Linting sketch in ClosedCube_SHT31D_Arduino/examples/whoiam

Linter results for project: no errors or warnings

-------------------

Linter results for projects: 0 ERRORS, 1 WARNINGS

@github-actions github-actions bot merged commit 9284cee into arduino:main Jan 30, 2025
14 checks passed
@github-actions GitHub Actions
Copy link
Contributor

Your submission has now been accepted! Thanks for your contribution to the Arduino Library Manager index.

The library(s) will be available for installation via Library Manager within a day's time.

You can check the logs from the Library Manager indexer for your library(s) here:
http://downloads.arduino.cc/libraries/logs/github.com/malarz-supla/ClosedCube_SHT31D_Arduino/

github-actions bot pushed a commit that referenced this pull request Jan 30, 2025
@ArduinoBot
Add submission # 5850
7a1e39e 
#5850
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 left review comments

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
topic: submission Add library to the list
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malarz-supla @per1234