Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not publish when nothing is being changed/updated #103

Open
EdwardLu2018 opened this issue Aug 11, 2021 · 1 comment
Open

Do not publish when nothing is being changed/updated #103

EdwardLu2018 opened this issue Aug 11, 2021 · 1 comment

Comments

@EdwardLu2018
Copy link
Member

Say we have this series of calls (in a loop, or something):

scene.update_object(box, click_listener=True)
scene.update_object(box, click_listener=True)
scene.update_object(box, click_listener=True)
scene.update_object(box, click_listener=True)
scene.update_object(box, click_listener=True)
etc...

Only the first call should actually do the publishing (make a network call), the rest should not do anything. The library should recognize that the click-listener of the box is already true and not do anything when updating.

@hi-liang
Copy link
Member

Wondering what the overhead would be like to deep-compare each pending publish JSON msg from the preceding one, ignoring animation types and so forth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants