Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minify main.js #161

Open
kepano opened this issue Aug 20, 2024 · 1 comment · May be fixed by #163
Open

Minify main.js #161

kepano opened this issue Aug 20, 2024 · 1 comment · May be fixed by #163
Labels
help wanted Accepting PRs for this feature requests

Comments

@kepano
Copy link

kepano commented Aug 20, 2024

Releases of Natural Language Dates use an unminified version of main.js. This causes the plugin to take longer to load than necessary. By adding a minify step to the build script, you should be able to significantly speed up the app load time, particularly on mobile.

@argenos
Copy link
Owner

argenos commented Nov 14, 2024

I'm afraid I currently can't devote time to this. Happy to accept a PR.

@argenos argenos added the help wanted Accepting PRs for this feature requests label Nov 14, 2024
Kageetai added a commit to Kageetai/nldates-obsidian that referenced this issue Nov 25, 2024
Fixes argenos#161

Add minification to the build process for `main.js`.

* **rollup.config.js**
  - Import `esbuild` from `rollup-plugin-esbuild` and `terser` from `rollup-plugin-terser`.
  - Add `esbuild` and `terser` to the `plugins` array for minification.

* **package.json**
  - Add `rollup-plugin-esbuild` as a devDependency.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/argenos/nldates-obsidian/issues/161?shareId=XXXX-XXXX-XXXX-XXXX).
@Kageetai Kageetai linked a pull request Nov 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Accepting PRs for this feature requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants