Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

istio-operator argocd application is pointing to targetRevision: HEAD #135

Open
amybachir opened this issue Jun 16, 2021 · 2 comments
Open

Comments

@amybachir
Copy link

amybachir commented Jun 16, 2021

Should the istio-operator argocd application sync from HEAD ? I think it might be a better idea to sync from a specific version.
https://github.com/argoflow/argoflow-aws/blob/master/distribution/argocd-applications/istio-operator.yaml#L10

Which version of istio-operator was the kubeflow installation tested with?

@karlschriek
Copy link
Contributor

hi @amybachir , thanks for poiting this out. I also saw this a few days ago. The HEAD here just points to which Helm chart will be used, the actual operator version is set in the helm parameters further down (1.10.2). But it probably makes sense to set a hard reference here that renovate also keeps up to take.

@davidspek
Copy link
Member

The chart version is actually 1.7 strangely enough. So I'm not sure what tag on GitHub that should point at.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants