-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
logs not getting written when multiprocessing_context is spawn or forkserver #131
Comments
Thanks for the merge of PR #130. The dlp.log has the same problem, but is more complicated because of the ENTER and EXIT code that is use to implement the: |
@krehm This has been fixed by @hariharan-devarajan, the corresponding PR is merged. Could you test it again whether it is working? |
I will be out of the office until Tuesday, but will give it a try then. |
I have not had time yet to do full testing, I am chasing another problem at the moment. But what I do notice is that when I do a MLPerf run (using 'main' branch) that it sets workflow.profiling=False, yet when I run unet3d with 'spawn' multiprocessing_context, I see messages that imply that profiling is running. So maybe child processes, at least in spawn mode, are ignoring args.do_profiling. |
I just opened PR #130 to fix dlio.log so that it gets reopened in spawn and forkserver child
processes so that the child log messages are not lost.
The same problem exists with dlp.log, but some of the code that needs to change is in repository
dlio-profiler. Once that is updated and its release number is bumped, then changes can
be made in dlio_benchmark to use the newer dlio-profiler version.
The text was updated successfully, but these errors were encountered: