Skip to content

Commit 9127d63

Browse files
authored
fix: update values file and update inconsistent default values (#655)
Signed-off-by: Anand Kumar Singh <anandrkskd@gmail.com>
1 parent bbfa434 commit 9127d63

File tree

3 files changed

+6
-52
lines changed

3 files changed

+6
-52
lines changed

install/helm-repo/argocd-agent-agent/README.md

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -42,12 +42,6 @@ Kubernetes: `>=1.24.0-0`
4242
| logLevel | string | `"info"` | Log level for the agent. |
4343
| metricsPort | string | `"8181"` | Metrics server port exposed by the agent. |
4444
| namespaceOverride | string | `""` | Override namespace to deploy the agent into. Leave empty to use the release namespace. |
45-
| networkPolicy.enabled | bool | `true` | |
46-
| networkPolicy.redis.agentSelector."app.kubernetes.io/name" | string | `"argocd-agent-agent"` | |
47-
| networkPolicy.redis.enabled | bool | `true` | |
48-
| networkPolicy.redis.name | string | `"allow-agent-to-redis"` | |
49-
| networkPolicy.redis.namespace | string | `""` | |
50-
| networkPolicy.redis.redisSelector."app.kubernetes.io/name" | string | `"argocd-redis"` | |
5145
| nodeSelector | object | `{}` | Node selector for scheduling the agent Pod. |
5246
| podAnnotations | object | `{}` | Additional annotations to add to the agent Pod. |
5347
| podLabels | object | `{}` | Additional labels to add to the agent Pod. |
@@ -85,10 +79,10 @@ Kubernetes: `>=1.24.0-0`
8579
| tests.enabled | string | `"true"` | Enable chart tests. |
8680
| tests.image | string | `"bitnamilegacy/kubectl"` | Test image. |
8781
| tests.tag | string | `"1.33.4"` | Test image tag. |
88-
| tlsClientCertPath | string | `"/app/config/tls/tls.crt"` | Path to the TLS client certificate. |
82+
| tlsClientCertPath | string | `""` | Path to the TLS client certificate. |
8983
| tlsClientInSecure | string | `"false"` | Whether to skip TLS verification for client connections. |
90-
| tlsClientKeyPath | string | `"/app/config/tls/tls.key"` | Path to the TLS client key. |
91-
| tlsRootCAPath | string | `"/app/config/tls/ca.crt"` | Path to the TLS root CA certificate. |
84+
| tlsClientKeyPath | string | `""` | Path to the TLS client key. |
85+
| tlsRootCAPath | string | `""` | Path to the TLS root CA certificate. |
9286
| tlsRootCASecretName | string | `"argocd-agent-ca"` | Name of the Secret containing root CA certificate. |
9387
| tlsSecretName | string | `"argocd-agent-client-tls"` | Name of the TLS Secret containing client cert/key for mTLS. |
9488
| tolerations | list | `[]` | Tolerations for the agent Pod. |

install/helm-repo/argocd-agent-agent/values.schema.json

Lines changed: 0 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -207,46 +207,6 @@
207207
"tlsClientCertPath": { "type": "string", "description": "Path to client cert inside container" },
208208
"tlsRootCAPath": { "type": "string", "description": "Path to Root CA inside container" },
209209

210-
"networkPolicy": {
211-
"type": "object",
212-
"description": "NetworkPolicy configuration",
213-
"additionalProperties": false,
214-
"properties": {
215-
"enabled": {
216-
"type": "boolean",
217-
"description": "Whether to enable NetworkPolicy"
218-
},
219-
"redis": {
220-
"type": "object",
221-
"additionalProperties": false,
222-
"properties": {
223-
"enabled": {
224-
"type": "boolean",
225-
"description": "Whether to enable Redis NetworkPolicy"
226-
},
227-
"name": {
228-
"type": "string",
229-
"description": "Name of the NetworkPolicy"
230-
},
231-
"namespace": {
232-
"type": "string",
233-
"description": "Namespace for the NetworkPolicy"
234-
},
235-
"redisSelector": {
236-
"type": "object",
237-
"additionalProperties": { "type": "string" },
238-
"description": "Selector for Redis pods"
239-
},
240-
"agentSelector": {
241-
"type": "object",
242-
"additionalProperties": { "type": "string" },
243-
"description": "Selector for agent pods"
244-
}
245-
}
246-
}
247-
}
248-
},
249-
250210
"service": {
251211
"type": "object",
252212
"description": "Service configuration for metrics and healthz",

install/helm-repo/argocd-agent-agent/values.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -129,11 +129,11 @@ cacheRefreshInterval: "10s"
129129
# -- Keep-alive interval for connections.
130130
keepAliveInterval: "50s"
131131
# -- Path to the TLS client key.
132-
tlsClientKeyPath: "/app/config/tls/tls.key"
132+
tlsClientKeyPath: ""
133133
# -- Path to the TLS client certificate.
134-
tlsClientCertPath: "/app/config/tls/tls.crt"
134+
tlsClientCertPath: ""
135135
# -- Path to the TLS root CA certificate.
136-
tlsRootCAPath: "/app/config/tls/ca.crt"
136+
tlsRootCAPath: ""
137137

138138
## @section Services
139139
# -- Service configuration for metrics and healthz endpoints.

0 commit comments

Comments
 (0)