Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character visibility #1

Open
ZeroThe2nd opened this issue Oct 18, 2018 · 7 comments
Open

Character visibility #1

ZeroThe2nd opened this issue Oct 18, 2018 · 7 comments

Comments

@ZeroThe2nd
Copy link

While using the theme for PHP and JavaScript coding, the characters ,(":'); and the line numbering in general are rather hard to see on the darker background as they are even darker grey than commented text, and the same colour as the marker for the space key (which are actually perfect for me).

The (")' characters are also inconsistent between PHP and JavaScript.

Example with a block of JavaScript code:
image

Example with a block of PHP code:
image

@argyleink
Copy link
Owner

nice eye.
the darkness is intentional, but the inconsistency between language is something i can hack on 👍

@ZeroThe2nd
Copy link
Author

I'm aware that the darkness of the theme is intentional, and I love it a lot. That's why I use it. However the contrast between the characters makes digging through code a bit hard ><"
FYI, I'm working from a MacBook Pro screen, so it's not my contrast settings (you wouldn't believe how often I've seen that being an issue).

@ZeroThe2nd
Copy link
Author

Here are some code examples you can work with 🙂
ScriptSamples.zip

@argyleink
Copy link
Owner

i havent forgotten... been busy releasing a project OSS. it's still on my radar and i intend to do this.

@argyleink
Copy link
Owner

in the interim, you may find a new theme i made is handling some of your files better. find it here, it's fairly similar https://vscodethemes.com/e/ArgyleInk.kung-fury

@ZeroThe2nd
Copy link
Author

The theme looks great, but it's for vscode and not for sublime text sadly ><"

@argyleink
Copy link
Owner

it is for sublime as well https://packagecontrol.io/packages/Kung%20Fury

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants