Skip to content

Make close! a no-op for fully iterated queries? #492

@ameligrana

Description

@ameligrana

currently

julia> using Ark

julia> struct Position
           x::Float64
           y::Float64
       end

julia> world = World(Position)
World(entities=0, comp_types=(Position))

julia> new_entity!(world, (Position(1, 1),))

julia> query = Query(world, (Position,))

julia> for (entities, positions) in query
           println("a")
       end

julia> close!(query)
ERROR: InvalidStateException: unbalanced unlock. Did you close a query that was already iterated?
Stacktrace:
 [1] _unlock
   @ ~/.julia/dev/Ark/src/lock.jl:18 [inlined]
 [2] close!(q::Query{World{…}, Tuple{…}, Tuple{…}, Val{…}, Tuple{…}, Val{…}, 1, 1})
   @ Ark ~/.julia/dev/Ark/src/query.jl:269
 [3] top-level scope
   @ REPL[7]:1
Some type information was truncated. Use `show(err)` to see complete types.

though, a no-op is probably better, and I think @mlange-42 you implemented already in ark, right?

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions