Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tco/tmiv schemaとTmtcGenericC2aServerにdescription他を追加する #246

Open
shunsuke-shimomura opened this issue Jun 10, 2024 · 2 comments · May be fixed by #248
Open

tco/tmiv schemaとTmtcGenericC2aServerにdescription他を追加する #246

shunsuke-shimomura opened this issue Jun 10, 2024 · 2 comments · May be fixed by #248
Assignees
@shunsuke-shimomura

Comments

@shunsuke-shimomura
Copy link
Contributor

shunsuke-shimomura commented Jun 10, 2024 •
edited
Loading

基本的にtmtc_generic_c2a.protoに書かれてるTODOを実装する
descriptionを追加したい箇所は

  • tco::Schema
  • tco::ParamSchema
  • tmiv::FieldSchema

他にも tmiv::FieldSchemaにあるDataTypeとvariantsをtmtcGenericC2aServerから流したい
@shunsuke-shimomura shunsuke-shimomura self-assigned this Jun 10, 2024
@shunsuke-shimomura
Copy link
Contributor Author

@KOBA789 よく見るとgaia-tmtcとtmtc-c2aの両方にSchemaが存在していそうなのですが、これは歴史的経緯によるものですか？それとも機能的に何かを果たしていますか？レポジトリ内で検索した限りだとどこにも使われてなさそうに見えました。

@KOBA789
Copy link
Member

KOBA789 commented Jun 10, 2024

出先なので精査せずに答えちゃいますが、歴史的経緯によって残っているだけのもののはずです

@shunsuke-shimomura shunsuke-shimomura linked a pull request Jun 10, 2024 that will close this issue
Open
@shunsuke-shimomura shunsuke-shimomura linked a pull request Jun 10, 2024 that will close this issue
GetSatelliteSchemaの戻り値で各種descriptionを含めるように変更 #248
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shunsuke-shimomura shunsuke-shimomura

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GetSatelliteSchemaの戻り値で各種descriptionを含めるように変更 arkedge/gaia
2 participants
@KOBA789 @shunsuke-shimomura