Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic "refresh-cluster" CLI Call #32

Open
chelma opened this issue Apr 25, 2023 · 0 comments
Open

Add basic "refresh-cluster" CLI Call #32

chelma opened this issue Apr 25, 2023 · 0 comments
Labels
Capture Resilience Work to make traffic capture more resilient to changes in load, configuration, and sources

Comments

@chelma
Copy link
Collaborator

chelma commented Apr 25, 2023

Description

Currently, we're using the create-cluster call to update the configuration of existing Cluster. While convenient, this isn't the most obvious interface convention. Additionally, there is a need to update configuration beyond just the Cluster's CloudFormation stacks (such as the VPC Endpoints created in each user-vpc subnet) when the user's setup changes. Performing those changes in configuration currently requires deleting/recreating capture setups which is not a good experience.

This task is to make a new, basic refresh-cluster CLI call that accomplishes the following:

  • Updates the CloudFormation configuration of the Cluster stacks to reflect changes in desired ASG capacity, etc
  • Updates the CloudFormation configuration of the Mirroring stacks to reflect changes in the user-vpc subnet configuration

This task is NOT focused on managing/updating per-ENI Mirroring Sessions and configuration except to accomplish the above two points.

Acceptance Criteria

  • Add a new refresh-cluster call with the following properties
    • Should update the stacks created by the user's previous create-cluster invocation
    • The user should not need to re-enter the arguments used to create the cluster initially every time refresh-cluster is invoked
    • If the subnets in the user's VPCs have changed, the command should handle this gracefully
      • Missing subnets have any remaining per-ENI configuration deleted
      • CDK invocation creates the subnet-specific resources for any new subnets
      • Per-Eni mirroring configuration for the new subnets created
  • create-cluster should abort if the cluster already exists and direct the user to the refresh-cluster call
  • Given the variety of ways that changes in CloudFormation configuration can cause deployments to fail in sets of interdependent stacks, user-intervention is expected if something goes wrong.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Capture Resilience Work to make traffic capture more resilient to changes in load, configuration, and sources
Projects
None yet
Development

No branches or pull requests

1 participant