Options in the menu, but not in the code

[markusb]

I'm looking to implement a feature to send a 5-tone ZVEI2 sequence as it is used by REGA (Swiss Helicopter Rescue).

In the process I came across a feature which is configurable in the radio settings, but not implemented in the code.
The PTT_ID TX_UP, which is supposed to send some DTMF at the start of the transmission is not implemented at all.
The PTT_ID TX_BOTH, which sends DTMF at the start and end of the transmission is only sending at the end, making TX_BOTH equivalent to TX_DOWN.

It looks to me like we should remove the items from the menu as they are not implemented in the code. It seems nobody is using that anyway.

[MrHoerby]

In the broadcast version of 3.9 the function in menu item 49 for UP+DOWN CODE works for me.

[markusb]

Interesting. I can not see the code implementing the DTMF at the start of the transmission. At the end of the transmission it is there. Maybe I'm looking cross-eyed...

[armel]

Hi,

Take a look here:

https://github.com/armel/uv-k5-firmware-custom/blob/main/app/dtmf.c#L450-L466

[markusb]

This section is mostly about sending the DTMF at the end of the transmission.
Only this section here is about DTMF at the begin of the transmisson:

https://github.com/armel/uv-k5-firmware-custom/blob/main/app/dtmf.c#L464-L466

However, a did follow the code better this time and found it.

But the only thing it does is setting pString to the DTMF_UP_CODE.
If I follow pString, I find that it is used ar argument to BK4819_PlayDTMFString.
BK4819_PlayDTMFString is caller in dtmf.c on line 100 in DTMF_SendEndOfTransmission and on line 486 in DTMF_Reply.
DTMF_SendEndOfTransmission is not at the start of the transmission.
DTMF_Replay is called in line 201 of FUNCTION_Transmit <<<---

Here we have it. A bit convoluted, though.

Thank you for your patience. Takes time to get used to the codebase. Unfortunately the names do not always reflect the function and there are not many comments describing the structure.

[armel]

@markusb You know, a lot of developers spent a lot of time on the code for this firmware. DualTachyon, One Of Eleven, Egzumer and now me, not forgetting all the external contributors. Some comments are indeed missing. Some parts of the code deserve to be completely rewritten. But that would be a huge job that nobody is prepared to do today.

[markusb]

I fully understand.

While it may be nice to have better comments, the style is quite clean and most variable names are quite explicit.

[MrHoerby]

Look in menu items 47 and 48 to see if there is a code there. If there is nothing there (e.g. 123 456), you can enter it there with Chirp!

Remember, if the device is in a deep sleep it takes too long until it is awake to read the code.
Of course I mean the receiving device!