-
-
Notifications
You must be signed in to change notification settings - Fork 686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow fold kwarg in arrow.get() #872
Comments
Hello, I am interested in implementing this. After reading the arrow.get() API, I still find the description ambiguous. Can you elaborate on "which side of an ambiguous datetime"? Are both tzinfo="US/Pacific", fold=1 new features and what does fold=1 mean? thanks. |
@systemcatch |
Hi @yiransii that is exactly what I meant by fold. |
@systemcatch I traced back to the Line 250 in 1278a21
I am wondering if we are still updating the enfold method in the arrow constructor? Line 93 in 1278a21
Thanks! |
Hey @yiransii for now we can stick with the |
hey @systemcatch, |
@sania-dsouza we would expect the following. >>> arrow.Arrow(2001, 10, 28, 1, tzinfo="US/Pacific")
<Arrow [2001-10-28T01:00:00-07:00]>
>>> arrow.Arrow(2001, 10, 28, 1, tzinfo="US/Pacific", fold=1)
<Arrow [2001-10-28T01:00:00-08:00]> |
Hello @systemcatch BTW, this notation was already working, since all the arguments would be passed into Arrow constructor 🙃
|
Currently there is no way to specify which side of an ambiguous datetime we want when creating with
arrow.get()
. It'd be nice to be able to do the following.The text was updated successfully, but these errors were encountered: