Skip to content

Commit fc72136

Browse files
committed
doc: update contributing instructions
1 parent 307c4be commit fc72136

File tree

4 files changed

+38
-40
lines changed

4 files changed

+38
-40
lines changed

CONTRIBUTING.md

+17-5
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,19 @@
11
# How to contribute
22

3+
All contributions, ideas and bug reports are more than welcome!
4+
We encourage you to open an [issue](https://github.com/artefactory-global/streamlit_prophet/issues) for any change you would like to make on this project.
5+
6+
## Workflow
7+
8+
If you wish to contribute, please follow this process:
9+
10+
* Fork the main branch of the repository.
11+
* Clone your fork locally.
12+
* Set up your environment (see `Dependencies` section below).
13+
* Commit your work after ensuring it meets the guidelines described below (code style, checks).
14+
* Push to your fork.
15+
* Open a pull request from your fork back to the original main branch.
16+
317
## Dependencies
418

519
We use `poetry` to manage the [dependencies](https://github.com/python-poetry/poetry).
@@ -17,7 +31,7 @@ make install
1731

1832
To activate your `virtualenv` run `poetry shell`.
1933

20-
## Codestyle
34+
## Code style
2135

2236
After you run `make install` you can execute the automatic code formatting.
2337

@@ -45,7 +59,5 @@ Before submitting your code please do the following steps:
4559

4660
## Other help
4761

48-
You can contribute by spreading a word about this library.
49-
It would also be a huge contribution to write
50-
a short article on how you are using this project.
51-
You can also share your best practices with us.
62+
You can also contribute by spreading a word about this library.
63+
We would be very interested to hear how you are using the app and what are your best practices.

README.md

+8-22
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,11 @@
1212
[![Semantic Versions](https://img.shields.io/badge/%F0%9F%9A%80-semantic%20versions-informational.svg)](https://github.com/artefactory-global/streamlit_prophet/releases)
1313
[![License](https://img.shields.io/badge/License-MIT-informational.svg)](https://github.com/artefactory-global/streamlit_prophet/blob/main/LICENSE)
1414

15-
Deploy a [Streamlit](https://streamlit.io/) app to visually train, evaluate and optimize a [Prophet](https://facebook.github.io/prophet/) forecasting model
15+
Deploy a [Streamlit](https://streamlit.io/) app to train, evaluate and optimize a [Prophet](https://facebook.github.io/prophet/) forecasting model visually
1616

1717
</div>
1818

19+
https://user-images.githubusercontent.com/56996548/126762714-f2d3f3a1-7098-4a86-8c60-0a69d0f913a7.mp4
1920

2021
## 💻 Requirements
2122

@@ -27,7 +28,7 @@ Please make sure you have one of these versions installed to be able to run the
2728

2829
### Operating System
2930
Windows users have to install [WSL2](https://docs.microsoft.com/en-us/windows/wsl/) to download the package.
30-
This is due to the incompatibility between Windows and Prophet's main dependency (pystan).
31+
This is due to an incompatibility between Windows and Prophet's main dependency (pystan).
3132
Other operating systems should work fine.
3233

3334
## ⚙️ Installation
@@ -55,7 +56,7 @@ pip install -U streamlit_prophet
5556

5657
Or from the main branch of this repository:
5758
```bash
58-
pip install git+ssh://git@github.com/artefactory-global/streamlit_prophet.git@main
59+
pip install git+https://github.com/artefactory-global/streamlit_prophet.git@main
5960
```
6061

6162

@@ -67,7 +68,7 @@ Once installed, run the following command from CLI to open the app in your defau
6768
streamlit_prophet deploy dashboard
6869
```
6970

70-
Now you can train, evaluate and optimize a forecasting model in just a few clicks.
71+
Now you can train, evaluate and optimize forecasting models in a few clicks.
7172
All you have to do is to upload a time series dataset.
7273
This dataset should be a csv file that contains a date column, a target column and optionally some features, like on the example below:
7374

@@ -85,27 +86,12 @@ with the model previously trained.
8586

8687
Once you are satisfied, click on "save experiment" to download all plots and data locally.
8788

88-
https://user-images.githubusercontent.com/56996548/126762714-f2d3f3a1-7098-4a86-8c60-0a69d0f913a7.mp4
89-
9089

9190
## 🛠️ How to contribute ?
9291

93-
If you want to contribute to the development of this package:
94-
95-
1. Clone the repository:
96-
```bash
97-
git clone git@github.com:artefactory-global/streamlit_prophet.git
98-
```
92+
All contributions, ideas and bug reports are welcome!
93+
We encourage you to open an [issue](https://github.com/artefactory-global/streamlit_prophet/issues) for any change you would like to make on this project.
9994

100-
2. If you don't have `Poetry` installed, run:
101-
```bash
102-
make download-poetry; export PATH="$HOME/.poetry/bin:$PATH"
103-
```
104-
105-
3. Initialize poetry and install `pre-commit` hooks:
106-
```bash
107-
make install
108-
```
10995

110-
And you are ready to develop ! For more information, see [`CONTRIBUTING`](https://github.com/artefactory-global/streamlit_prophet/blob/main/CONTRIBUTING.md) instructions.
96+
For more information, see [`CONTRIBUTING`](https://github.com/artefactory-global/streamlit_prophet/blob/main/CONTRIBUTING.md) instructions.
11197
If you wish to containerize the app, see [`DOCKER`](https://github.com/artefactory-global/streamlit_prophet/blob/main/DOCKER.md) instructions.

poetry.lock

+12-12
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pyproject.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ build-backend = "poetry.core.masonry.api"
77
[tool.poetry]
88
name = "streamlit_prophet"
99
version = "1.0.0"
10-
description = "Deploy a Streamlit app to visually train, evaluate and optimize a Prophet forecasting model."
10+
description = "Deploy a Streamlit app to train, evaluate and optimize a Prophet forecasting model visually."
1111
readme = "README.md"
1212
authors = [
1313
"Maxime Lutel <maxime.lutel@artefact.com>"

0 commit comments

Comments
 (0)