Fix OIDC plugin getOidcInstance() logic

Fix issue with arOidc::getOidcInstance() where if it were called a
second time getOidcInstance() would return null instead of an instance
of OpenIDConnectClient.

Author: sbreker

plugins/arOidcPlugin/lib/arOidc.class.php

@@ -21,7 +21,6 @@
 
 class arOidc
 {
-    protected static $oidcIsInitialized = false;
     protected static $validTokenNames = ['access-token', 'id-token', 'verified-claims', 'user-info'];
     protected static $validUserMatchingSources = ['oidc-email', 'oidc-username'];
 
@@ -32,11 +31,6 @@ class arOidc
      */
     public static function getOidcInstance()
     {
-        // Return if already initialized.
-        if (self::$oidcIsInitialized) {
-            return;
-        }
-
         $oidc = new OpenIDConnectClient();
 
         // Validate redirect URL.
@@ -46,8 +40,6 @@ public static function getOidcInstance()
         }
         $oidc->setRedirectURL($redirectUrl);
 
-        self::$oidcIsInitialized = true;
-
         return $oidc;
     }