Skip to content

Conversation

@almdudleer
Copy link
Collaborator

@almdudleer almdudleer commented Jul 13, 2022

I'm used to applying autoformatting when making changes, so that there is a consistent codestyle throughout the project. So I tweaked my formatters (PyCharm for .R and CLion for .cpp) to match some style, which was already used in your code. But because there were multiple different styles and some spaces were not in place, there are some changes.

By the way, Github shows wrong diffs, there are no real code changes, just spaces and newlines moved around.

@almdudleer
Copy link
Collaborator Author

almdudleer commented Jul 13, 2022

It would also be good to conform to a styleguide, for the styling to be familiar to everyone and the code easy to read.
This is a common one, as far as I've heard: https://style.tidyverse.org/index.html. There are also automatic tools for it, lintr and styler. However, there would be more changes than spaces, names of files, variables and functions being the most damaging. But it's better to do it sooner than later. I can apply it when (and if) you are ready and agree.

@almdudleer almdudleer force-pushed the almdudleer/formatting branch from 7f8c99b to 9b2234e Compare July 14, 2022 10:10
@almdudleer almdudleer force-pushed the almdudleer/formatting branch from 9b2234e to 86f2a45 Compare July 15, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants