Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run the post-processing steps in the prepare pipeline in parallel #14

Open
4 tasks done
aryarm opened this issue Jun 9, 2020 · 0 comments
Open
4 tasks done

run the post-processing steps in the prepare pipeline in parallel #14

aryarm opened this issue Jun 9, 2020 · 0 comments
Assignees
Labels
enhancement New feature or request low-priority
Milestone

Comments

@aryarm
Copy link
Owner

aryarm commented Jun 9, 2020

At the end of the prepare pipeline, a couple of post-processing steps are performed on the merged TSV before we feed it to the classify pipeline. All of the scripts used in these steps support reading from stdin and writing to stdout except for fillna.bash

  • remove the first parameter from fillna.bash and make it read the TSV from stdin, instead
  • connect all of the post-processing steps together via pipes
    • this will allow us to save on file IO and wasted time compressing and uncompressing the file between steps
  • remove extra config params that nobody uses (like keepna, pure_numerics, and friends) - they just make things more complicated
  • mark extra files as temp
@aryarm aryarm added enhancement New feature or request low-priority labels Jun 9, 2020
@aryarm aryarm added this to the VarCA v2.0.0 milestone Jul 12, 2021
@aryarm aryarm self-assigned this Jul 12, 2021
aryarm added a commit that referenced this issue Jul 16, 2021
…#14)

also remove extra config params that nobody uses and mark some extra files as temp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low-priority
Projects
None yet
Development

No branches or pull requests

1 participant