Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GeoInterface integration #18

Open
aryavorskiy opened this issue Feb 6, 2025 · 0 comments
Open

GeoInterface integration #18

aryavorskiy opened this issue Feb 6, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@aryavorskiy
Copy link
Owner

Currently the code that is responsible for creating lattices with different shapes is a total mess. It uses its own rather crude library of shape primitives, which seriously limits its applications. A good idea is to hook it up to GeoInterface.jl in some way.

  • Does GeoInterface ship its own geometric primitives? What library to reexport/recommend if not?
  • Which of LatticeModels.jl own primitives will stay? How to make sure the changes were not breaking?
  • How to estimate the size of the lattice for a given shape? Right now it uses circumscribed spheres - 100% not the best way.
@aryavorskiy aryavorskiy added the enhancement New feature or request label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aryavorskiy