Use standardrb as code formatter for this repo

Author: Mange

.solargraph.yml

@@ -0,0 +1,16 @@
+---
+include:
+  - "**/*.rb"
+exclude:
+  - spec/**/*
+  - test/**/*
+  - vendor/**/*
+  - ".bundle/**/*"
+require: []
+domains: []
+plugins:
+  - solargraph-standardrb
+reporters:
+  - standardrb
+require_paths: []
+max_files: 5000

Changelog.md

@@ -4,6 +4,7 @@
 
 * Enhancements
   * Test with Ruby 2.7 - [aried3r (Anton Rieder)](https://github.com/aried3r) (#167)
+  * Add standardrb as code formatter
 
 ### 4.0.0
 

Gemfile

@@ -1,7 +1,10 @@
 # frozen_string_literal: true
 
-source 'https://rubygems.org'
+source "https://rubygems.org"
 gemspec
 
 # Added here so it does not show up on the Gemspec; I only want it for CI builds
-gem 'codecov', group: :test, require: false
+gem "codecov", group: :test, require: false
+# Not actually required to run the tests for the gem, but a real convenience
+# for local development.
+gem "standard", group: [:test, :development], require: false

Rakefile

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'bundler/setup'
+require "bundler/setup"
 
 Bundler::GemHelper.install_tasks
 
@@ -10,4 +10,4 @@ task :spec do
 end
 
 desc "Default: Run specs"
-task :default => :spec
+task default: :spec

lib/roadie.rb

@@ -3,30 +3,30 @@
 module Roadie
 end
 
-require 'roadie/version'
-require 'roadie/errors'
+require "roadie/version"
+require "roadie/errors"
 
-require 'roadie/utils'
-require 'roadie/deduplicator'
+require "roadie/utils"
+require "roadie/deduplicator"
 
-require 'roadie/stylesheet'
-require 'roadie/selector'
-require 'roadie/style_property'
-require 'roadie/style_attribute_builder'
-require 'roadie/style_block'
+require "roadie/stylesheet"
+require "roadie/selector"
+require "roadie/style_property"
+require "roadie/style_attribute_builder"
+require "roadie/style_block"
 
-require 'roadie/asset_provider'
-require 'roadie/provider_list'
-require 'roadie/filesystem_provider'
-require 'roadie/null_provider'
-require 'roadie/net_http_provider'
-require 'roadie/cached_provider'
-require 'roadie/path_rewriter_provider'
+require "roadie/asset_provider"
+require "roadie/provider_list"
+require "roadie/filesystem_provider"
+require "roadie/null_provider"
+require "roadie/net_http_provider"
+require "roadie/cached_provider"
+require "roadie/path_rewriter_provider"
 
-require 'roadie/asset_scanner'
-require 'roadie/markup_improver'
-require 'roadie/url_generator'
-require 'roadie/url_rewriter'
-require 'roadie/null_url_rewriter'
-require 'roadie/inliner'
-require 'roadie/document'
+require "roadie/asset_scanner"
+require "roadie/markup_improver"
+require "roadie/url_generator"
+require "roadie/url_rewriter"
+require "roadie/null_url_rewriter"
+require "roadie/inliner"
+require "roadie/document"

lib/roadie/asset_scanner.rb

@@ -43,15 +43,15 @@ def find_css
     # @see #find_css
     # @return [Enumerable<Stylesheet>] every extracted stylesheet
     def extract_css
-      stylesheets = @dom.css(STYLE_ELEMENT_QUERY).map { |element|
+      @dom.css(STYLE_ELEMENT_QUERY).map { |element|
         stylesheet = read_stylesheet(element)
         element.remove if stylesheet
         stylesheet
       }.compact
-      stylesheets
     end
 
     private
+
     STYLE_ELEMENT_QUERY = (
       "style:not([data-roadie-ignore]), " +
       # TODO: When using Nokogiri 1.6.1 and later; we may use a double :not here
@@ -75,7 +75,7 @@ def extract_css
     def read_stylesheet(element)
       if element.name == "style"
         read_style_element element
-      elsif element.name == "link" && element['media'] != "print" && element["href"]
+      elsif element.name == "link" && element["media"] != "print" && element["href"]
         read_link_element element
       end
     end
@@ -86,14 +86,14 @@ def read_style_element(element)
 
     def read_link_element(element)
       if Utils.path_is_absolute?(element["href"])
-        external_asset_provider.find_stylesheet! element['href'] if should_find_external?
+        external_asset_provider.find_stylesheet! element["href"] if should_find_external?
       else
-        normal_asset_provider.find_stylesheet! element['href']
+        normal_asset_provider.find_stylesheet! element["href"]
       end
     end
 
     def clean_css(css)
-      css.gsub(CLEANING_MATCHER, '')
+      css.gsub(CLEANING_MATCHER, "")
     end
 
     def should_find_external?

lib/roadie/cached_provider.rb

@@ -69,6 +69,7 @@ def find_stylesheet!(name)
     end
 
     private
+
     def cache_fetch(name)
       cache[name] || cache[name] = yield
     rescue CssNotFound

lib/roadie/deduplicator.rb

@@ -26,6 +26,7 @@ def apply
     end
 
     private
+
     attr_reader :input, :latest_occurance
 
     def has_duplicates?

lib/roadie/document.rb

@@ -152,6 +152,7 @@ def mode=(mode)
     end
 
     private
+
     VALID_MODES = %i[html xhtml xml].freeze
     private_constant :VALID_MODES
 
@@ -169,7 +170,7 @@ def inline(dom, options = {})
       Inliner.new(dom_stylesheets + [stylesheet], dom).inline(
         keep_uninlinable_css: keep_uninlinable_css,
         keep_uninlinable_in: keep_uninlinable_in,
-        merge_media_queries: merge_media_queries,
+        merge_media_queries: merge_media_queries
       )
     end
 
@@ -183,15 +184,15 @@ def serialize_document(dom)
       format = {
         html: save_options::AS_HTML,
         xhtml: save_options::AS_XHTML,
-        xml: save_options::AS_XML,
+        xml: save_options::AS_XML
       }.fetch(mode)
 
       dom.dup.to_html(
         save_with: (
           save_options::NO_DECLARATION |
           save_options::NO_EMPTY_TAGS |
           format
-        ),
+        )
       )
     end
 
@@ -208,9 +209,9 @@ def callback(callable, dom)
         # Arity checking is to support the API without bumping a major version.
         # TODO: Remove on next major version (v4.0)
         if !callable.respond_to?(:parameters) || callable.parameters.size == 1
-          callable.(dom)
+          callable.call(dom)
         else
-          callable.(dom, self)
+          callable.call(dom, self)
         end
       end
     end

lib/roadie/errors.rb

@@ -18,10 +18,10 @@ class InvalidUrlPath < Error
 
     def initialize(given_path, cause = nil)
       @cause = cause
-      if cause
-        cause_message = " Caused by: #{cause}"
+      cause_message = if cause
+        " Caused by: #{cause}"
       else
-        cause_message = ""
+        ""
       end
       super "Cannot use path \"#{given_path}\" in URL generation.#{cause_message}"
     end
@@ -52,11 +52,13 @@ def initialize(css_name, extra_message = nil, provider = nil)
     end
 
     protected
+
     def error_row
       "#{provider || "Unknown provider"}: #{extra_message || message}"
     end
 
     private
+
     # Redundant method argument is to keep API compatability without major version bump.
     # TODO: Remove argument on version 4.0.
     def build_message(extra_message = @extra_message)
@@ -76,6 +78,7 @@ def initialize(css_name, provider_list, errors)
     end
 
     private
+
     def build_message(extra_message)
       message = +%(Could not find stylesheet "#{css_name}": #{extra_message}\nUsed providers:\n)
       each_error_row(errors) do |row|

lib/roadie/filesystem_provider.rb

@@ -36,10 +36,16 @@ def find_stylesheet!(name)
       end
     end
 
-    def to_s() inspect end
-    def inspect() "#<#{self.class} #@path>" end
+    def to_s
+      inspect
+    end
+
+    def inspect
+      "#<#{self.class} #{@path}>"
+    end
 
     private
+
     def build_file_path(name)
       raise InsecurePathError, name if name.include?("..")
       File.join(@path, name[/^([^?]+)/])