Skip to content
This repository was archived by the owner on Sep 8, 2020. It is now read-only.
This repository was archived by the owner on Sep 8, 2020. It is now read-only.

Cast entities values assignments #42

@beroso

Description

@beroso

The parser are storing SimpleXML elements in the entities properties.
I think, for example, the code from Parser::buildCreditAccount:

....
$bankAccount->accountNumber = $statementResponse->BANKACCTFROM->ACCTID;
$bankAccount->routingNumber = $statementResponse->BANKACCTFROM->BANKID;
$bankAccount->accountType = $statementResponse->BANKACCTFROM->ACCTTYPE;
....

should be:

....
$bankAccount->accountNumber = (string)$statementResponse->BANKACCTFROM->ACCTID;
$bankAccount->routingNumber = (string)$statementResponse->BANKACCTFROM->BANKID;
$bankAccount->accountType = (string)$statementResponse->BANKACCTFROM->ACCTTYPE;
....

Metadata

Metadata

Assignees

No one assigned

    Labels

    BC breakChanges in this PR/issue would result in a BC breakenhancementThis adds new functionality or improves existing functionality.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions