Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: semicolon added to end of operations #89

Closed
sb335c opened this issue Jan 10, 2025 · 1 comment · Fixed by #90
Closed

bug: semicolon added to end of operations #89

sb335c opened this issue Jan 10, 2025 · 1 comment · Fixed by #90
Assignees
Labels
bug Something isn't working

Comments

@sb335c
Copy link

sb335c commented Jan 10, 2025

Hi, following up on the fix for issue #88

A semicolon is added to the end of an operation sql. This breaks existing code that already has a semicolon added at the end. For example:

We have a workflow that looks similar to an example in the docs:
https://cloud.google.com/dataform/docs/reference/sample-scripts#multiple-SQL-operations

DELETE FROM datatable where country = 'GB';
DELETE FROM datatable where country = 'FR';

So now, with the way the extention works, it creates compiled sql like this which is not valid syntax.

DELETE FROM datatable where country = 'GB';
DELETE FROM datatable where country = 'FR';
;
@ashish10alex
Copy link
Owner

@sb335c , should be fixed in v0.7.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants