-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: trigger table run & data preview directly from compiled web ui #77
Conversation
Nice, addition @ashish10alex! off topic - Hopefully i'll get some more time over soon to help out more :-) |
thanks @HampB , thank you, added ability to I was curious if you had tried the external dependencies feature and if it works for you ?. It will show you the option to retrieve them when you click the dependencies and dependents ? |
The Dataplex linage? tbh, saw it first time now. But it looks interesting and seems to work when looking at tables with external dependencies, I will play around with it some. Noticed that you cant collapse it once it's been opened, added a new bug issue for that. |
yup, it was a feature request request that randomly came about from within our team at work. It help to identify teams/people who might be using an output table that you have created. So incase you want to change the name of the table you have some estimate of impact and roughly know who to reach out to. -- Makes me wonder should we consider renaming the parent component text to something else ? to make people aware that it shows external lineage too ? |
Yeah, i think it will be really useful in the daily. Agree that the parent probably could get a better name, but I'm currently not sure what would be a good name. Maybe just simplify it to "Lineage" or "Data Lineage", but that's not optimal either. In the future it would also be nice to merge the external deps from dataplex with the deps generated from dataform, to reduce the need of two lists. But we would then need some way to deal with users that does not have the dataplex api or permissions in a nice way. |
"Data Lineage" does not seem bad, makes the user want to click it. I have changed it to that. There are a few reasons why external dependents from the api might be kept separate.
|
This is a nice addition. Got a few things I would bolt on top of this but as it stands, lgtm! |
The change is largely made to make the extension features more visible to a more casual user.
getDataformActionCmdFromActionList
Minor fixes for issues discovered while implementing this feature