fix: dry run not working with @@query_label #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashish10alex
changed the title
This was referenced Dec 25, 2024
ashish10alex
changed the title
ashish10alex
changed the title
feat: reduce surface area over which regex is performed
|
Ofcource, makes more sence. Your changes seems to work as intended. This looks good to me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While investigating the issue with dry runs failing when
@@query_labelsis set, I couldn’t pinpoint the exact cause. However, I’ve implemented a quick (and perhaps somewhat dirty) solution: dropping the@@query_labelsstatement during dry runs.Implementation:
The solution uses a regular expression to identify and remove the
@@query_labelsstatement. While the regex might not be entirely foolproof, it has worked in all the scenarios I’ve tested.Rationale:
Since query labels should not affect dry runs, I don’t foresee any issues with this approach. That said, if you have concerns or an alternative solution, Feel free to change it or let me know :-)