fix: when bootstrapping plugins build with --remote_download_outputs=toplevel (#7472)

gregmagolan · jbedard · commit e16bfdf1d691 · 2024-12-13T15:34:59.000-08:00
This is needed if build without the bytes is on. Same as #7471 but for
the plugin bootstrap.

---

### Changes are visible to end-users: no

### Test plan

- Covered by existing test cases

GitOrigin-RevId: b77cc4ffd668268f09bf1261777125570d3fb891
diff --git a/pkg/plugin/client/client.go b/pkg/plugin/client/client.go
@@ -85,7 +85,7 @@ func (c *clientFactory) New(aspectplugin types.PluginConfig, streams ioutils.Str
 			Stderr: &stderr,
 		}
 
-		err := bzl.RunCommand(buildStreams, nil, "build", aspectplugin.From)
+		err := bzl.RunCommand(buildStreams, nil, "build", "--remote_download_outputs=toplevel", aspectplugin.From)
 		if err != nil {
 			var exitErr *aspecterrors.ExitError
 			if errors.As(err, &exitErr) {

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ func (c *clientFactory) New(aspectplugin types.PluginConfig, streams ioutils.Str`
`85`	`85`	`Stderr: &stderr,`
`86`	`86`	`}`
`87`	`87`
`88`		`- err := bzl.RunCommand(buildStreams, nil, "build", aspectplugin.From)`
	`88`	`+ err := bzl.RunCommand(buildStreams, nil, "build", "--remote_download_outputs=toplevel", aspectplugin.From)`
`89`	`89`	`if err != nil {`
`90`	`90`	`var exitErr *aspecterrors.ExitError`
`91`	`91`	`if errors.As(err, &exitErr) {`