[Bug]: eslint does not work

[vlkv]

What happened?

I am desperately trying to make eslint work via aspect's rules_lint. I had 3 attempts:

• in monorepo at my work
• in my fork of basel_starters/js (their repo has everything configured but there is no 'hello world/cowsay' app there, so in my fork I have added it)
• finally I have lost faith in my bazel skills and decided to run some examples from the rules_lint/example (should have do it in the first place). Created an MRE in my fork because I had to add some minor flags+toolkits+bazelisk stuff there.

In all these three usecases eslint does not detect problems in my js/ts code, such as unused variable.

Version

Development (host) and target OS/architectures:

linux amd64

Output of bazel --version:

./bazelisk --version
bazel 7.5.0

Version of the Aspect rules, or other relevant rules from your
WORKSPACE or MODULE.bazel file:

bazel_dep(name = "aspect_rules_lint", version = "0.0.0")
bazel_dep(name = "aspect_rules_js", version = "2.0.0")
bazel_dep(name = "aspect_rules_swc", version = "2.0.0")
bazel_dep(name = "aspect_rules_ts", version = "3.0.0")

Language(s) and/or frameworks involved:

JavaScript/TypeScript, Eslint

How to reproduce

Use this fork of rules_lint which shows the MRE.

cd ./example
./bazelisk build //src:ts

Any other information?

Actual result NO ERRORS from eslint.
Expected result: there SHOULD BE SOME ERRORS from eslint! Because they present in the example/src/file.ts

[alexeagle]

Are you differentiating between errors and warnings? The eslint exit code is what determines whether Bazel will fail. Since you're running a bazel build nothing is going to fail for something like Unused variable for example, I'd expect is typically a warning.

[vlkv]

But I do not see any warnings either (if they are not shown by default, how to turn them on?). Anyway, I am testing a file.ts from your examples. It has two linter violations, the second one, as the comment says - should result in linter exit 1.

[alexeagle]

https://github.com/aspect-build/rules_lint/blob/main/docs/linting.md#usage

bazel build won't show lint warnings. You can use Aspect CLI like the bazel-starters/js repo does, or copy that shell script.

[vlkv]

Hello, I have made one more experiment:

• Added to eslint config this:

    rules: {
      "no-unused-vars": "error",
    },

• Added to example/src/file.ts this:

const unused = "dsfdsfdsf"; // this is an unused var linting violation

With such a config, this should be an error not a warning for sure.

Running cd example && ./bazelisk build //src:ts and got nothing:

% ./baselisk build //src:ts
Starting local Bazel server and connecting to it...
INFO: Invocation ID: 6462dc09-c36e-4a83-a4bd-35be3b2a08a9
...
INFO: Analyzed target //src:ts (357 packages loaded, 21464 targets configured).
INFO: Found 1 target...
Target //src:ts up-to-date:
  bazel-bin/src/file.js
Aspect //tools/lint:linters.bzl%eslint of //src:ts up-to-date (nothing to build)
INFO: Elapsed time: 19.539s, Critical Path: 0.24s
INFO: 2 processes: 1 internal, 1 linux-sandbox.
INFO: Build completed successfully, 2 total actions

So, still, the example which is provided by rules_lint itself seems to be not working.