From fe67950500b6899d7d1c2214f8bea44467068892 Mon Sep 17 00:00:00 2001 From: Emmanuel Date: Mon, 22 May 2023 12:17:32 +0100 Subject: [PATCH 1/2] fix: corrected achievement progress property name --- .phpunit.result.cache | 1 + src/Model/AchievementProgress.php | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) create mode 100644 .phpunit.result.cache diff --git a/.phpunit.result.cache b/.phpunit.result.cache new file mode 100644 index 0000000..19ba34c --- /dev/null +++ b/.phpunit.result.cache @@ -0,0 +1 @@ +{"version":1,"defects":[],"times":{"Assada\\Tests\\AchievementTest::testUnlocked":0.114,"Assada\\Tests\\AchievementTest::testSetup":0.015,"Assada\\Tests\\AchievementTest::testUnlock":0.022,"Assada\\Tests\\AchievementTest::testProgress":0.022,"Assada\\Tests\\AchievementTest::testRelationsLockedUnsynced":0.016,"Assada\\Tests\\AchievementTest::testRelationsLockedSynced":0.021,"Assada\\Tests\\AchievementTest::testUnlockedWithMorphMap":0.01,"Assada\\Tests\\AchievementTest::testAchieverMorphMap":0.01,"Assada\\Tests\\AchievementTest::testAchievementProgressMapToDetails":0.01,"Assada\\Tests\\ChainAchievementTest::testProgress":0.052}} \ No newline at end of file diff --git a/src/Model/AchievementProgress.php b/src/Model/AchievementProgress.php index 632e687..6c4de52 100644 --- a/src/Model/AchievementProgress.php +++ b/src/Model/AchievementProgress.php @@ -90,7 +90,7 @@ public function details(): BelongsTo */ public function isUnlocked(): bool { - if (!is_null($this->unlockedAt)) { + if (!is_null($this->unlocked_at)) { return true; } if ($this->points >= $this->details->points) { @@ -124,7 +124,7 @@ public function save(array $options = []): bool $this->id = Uuid::uuid4()->toString(); } $recentlyUnlocked = false; - if (is_null($this->unlockedAt) && $this->isUnlocked()) { + if (is_null($this->unlocked_at) && $this->isUnlocked()) { $recentlyUnlocked = true; $this->points = $this->details->points; $this->unlocked_at = Carbon::now(); From 6b116e2f83bdf0b484305390d94e9deee63c1560 Mon Sep 17 00:00:00 2001 From: Emmanuel Date: Mon, 22 May 2023 12:18:17 +0100 Subject: [PATCH 2/2] fix: corrected achievement progress property name --- .phpunit.result.cache | 1 - 1 file changed, 1 deletion(-) delete mode 100644 .phpunit.result.cache diff --git a/.phpunit.result.cache b/.phpunit.result.cache deleted file mode 100644 index 19ba34c..0000000 --- a/.phpunit.result.cache +++ /dev/null @@ -1 +0,0 @@ -{"version":1,"defects":[],"times":{"Assada\\Tests\\AchievementTest::testUnlocked":0.114,"Assada\\Tests\\AchievementTest::testSetup":0.015,"Assada\\Tests\\AchievementTest::testUnlock":0.022,"Assada\\Tests\\AchievementTest::testProgress":0.022,"Assada\\Tests\\AchievementTest::testRelationsLockedUnsynced":0.016,"Assada\\Tests\\AchievementTest::testRelationsLockedSynced":0.021,"Assada\\Tests\\AchievementTest::testUnlockedWithMorphMap":0.01,"Assada\\Tests\\AchievementTest::testAchieverMorphMap":0.01,"Assada\\Tests\\AchievementTest::testAchievementProgressMapToDetails":0.01,"Assada\\Tests\\ChainAchievementTest::testProgress":0.052}} \ No newline at end of file