feat(protos): add auction result to bundle protos #1795
+175
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itamarreif
force-pushed
the
itamarreif/auctioneer/eng-998
branch
from
da3b5f5
to
c00046b
Compare
itamarreif
force-pushed
the
itamarreif/auctioneer/eng-998
branch
from
c00046b
to
e50a5a0
Compare
itamarreif
force-pushed
the
itamarreif/auctioneer/eng-998
branch
from
e50a5a0
to
a2643ed
Compare
itamarreif
changed the base branch from
main
to
itamarreif/auctioneer/protos-v1-update
SuperFluffy
reviewed
Nov 8, 2024
| // The rollup will verify the signature and public key against its configuration, | ||
| // then unbundle the body into rollup transactions and execute them first in the | ||
| // block. | ||
| message AuctionResult { |
There was a problem hiding this comment.
I have to walk back my suggestion for calling this a Result because it would clash with a regular Rust Result: Result<AuctionResult, E>.
Let's go with WinningBundle instead?
There was a problem hiding this comment.
I think it's probably fine to just call this a SignedBundle? That's what it is and provides a more generic option. IE this could allow it to be a bundle generated and signed by a TEE and submitted.
The fact that this signer indicates it is a Auction Result bundle is an implementation detail for the rollup?
SuperFluffy
requested changes
Nov 15, 2024
itamarreif
force-pushed
the
itamarreif/auctioneer/eng-998
branch
from
a2643ed
to
d9eb0ab
Compare
itamarreif
force-pushed
the
itamarreif/auctioneer/protos-v1-update
branch
from
d1edce9
to
4287b94
Compare
itamarreif
force-pushed
the
itamarreif/auctioneer/eng-998
branch
from
d9eb0ab
to
b9bf28c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the auction result definition to the bundle api protos.
Background
The auctioneer chooses a winning bundle which it needs to submit in a
RollupDataSubmissionto the sequencer. The winning bundle needs to be signed first, and this PR adds a wrapper object that includes the signature and public key required to verify the signature was done by the correct Auctioneer.Changes
AuctionResultdefintion to the bundle apiChangelogs
AuctionResultdefinition to the bundle api protosRelated Issues
closes #1790