Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s2let_spin_lowered_normalization is not defined #13

Open
paddyroddy opened this issue Aug 5, 2020 · 3 comments
Open

s2let_spin_lowered_normalization is not defined #13

paddyroddy opened this issue Aug 5, 2020 · 3 comments
Labels

Comments

@paddyroddy
Copy link
Collaborator

s2let_spin_lowered_normalization is used in here https://github.com/astro-informatics/src_s2let/blob/master/src/main/matlab/s2let_curvelet_tiling.m but has no definition

@paddyroddy paddyroddy added the bug label Aug 5, 2020
@GasperJu
Copy link

Is this problem solved? Apparently, I'm facing a problem with the code that can be due to this.

@paddyroddy
Copy link
Collaborator Author

don't think so, at least not in main

@jasonmcewen
Copy link
Contributor

I found this helped function in some of the curvelet branches:

/*!
 * Computes the normalization factor for spin-lowered wavelets,
 * which is sqrt((l+s)!/(l-s)!).
 *
 * \param[in]  el    Harmonic index el.
 * \param[in]  spin  Spin number the wavelet was lowered from.
 */
static double s2let_spin_lowered_normalization(int el, int spin)
{
    double factor = 1;
    int s;

    for (s = -ABS(spin)+1; s <= ABS(spin); ++s)
    {
        factor *= el+s;
    }

    if (spin > 0)
        return sqrt(factor);
    else
        return sqrt(1.0/factor);
}

@jenniferyhchan Where was the curvelet implementation left? Did we ever merge into main? I seem to recall that we scratched the C implementation and just went for a Matlab implementation. Is that correct? Perhaps we should delete the old branches or merge to main if appropriate?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants