-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New output types #75
Comments
I've added the architecture for outputting residuals, so you can make the actual plotting code now, Earl. |
Now that I think about it, what exactly are we going to plot for the periodogram? We actually do two periodograms, one with coarse and one with fine precision, so which do we plot? Both? Do we just insert the fine periodogram into the coarse one? |
Yes, we can insert them. A periodogram (ordinarily) has frequencies or periods on the abscissa and an estimate of the spectral density on the ordinate. So basically we can plot (freqs, pgram) from here. That means we'll probably want to start returning the entire periodogram instead of just the max value. But it's no problem to have a more dense region of frequencies in some places of the plot. |
Just wanted to add to this comment chain what Earl observed recently. The periodogram text files can end up being enormous, Earl had one reach ~50MB in size. How do we deal with this? This makes |
In order to properly implement the residual table, we will need to have access to the times associated with the magnitudes. As we currently do pointless phasing, this is nigh impossible, so we need to resolve issue #77. This might be a painful process, as a lot of things are coupled to phased data >.> |
We've discussed over both Gmail chat and GitHub issues, a number of new output types we need to support. I've decided to make a checklist here. Feel free to edit this post by either (un)checking items, or adding new ones. I've separated them into tabular and plot outputs.
stdout
table, and instead output them as photometry tables: (phase, mag, err)T
/F
to flag inliers/outliers: (time, mag, inlier?)--output-periodogram-form={frequency,period}
optionstdout
stdout
The text was updated successfully, but these errors were encountered: