Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove telescope_focal_length from camera configuration #92

Open
wschoenell opened this issue Jul 24, 2015 · 1 comment
Open

Remove telescope_focal_length from camera configuration #92

wschoenell opened this issue Jul 24, 2015 · 1 comment

Comments

@wschoenell
Copy link
Contributor

There is already a configuration parameter focal_length on the telescope instrument.

__config__ = {"device": "/dev/ttyS0",
"model": "Fake Telescopes Inc.",
"optics": ["Newtonian", "SCT", "RCT"],
"mount": "Mount type Inc.",
"aperture": 100.0, # mm
"focal_length": 1000.0, # mm
# unit (ex., 0.5 for a half length focal reducer)
"focal_reduction": 1.0,
}

This confuses the user.

@wschoenell
Copy link
Contributor Author

My idea is to add a key named focal_length on ImageRequest dictionary where the value is set by being the telescope instrument focal_length configuration parameter. And, also, get rid of the focal_reduction configuration parameter. If there is a focal reducer, the user is responsible (and alerted on the documentation) to calculate correct focal length.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant