Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed the submenu not Closing when click #317

Merged
merged 3 commits into from
Jun 19, 2024
Merged

fix: fixed the submenu not Closing when click #317

merged 3 commits into from
Jun 19, 2024

Conversation

TenzDelek
Copy link
Contributor

@netlify Netlify
Copy link

netlify bot commented Apr 20, 2024 •
edited
Loading

✅ Deploy Preview for peaceful-ramanujan-288045 ready!

Name Link
🔨 Latest commit e5f7954
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/6672af5d96ba4000088661ed
😎 Deploy Preview https://deploy-preview-317--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thulieblack
Copy link
Member

/ptal

@asyncapi-bot
Copy link
Contributor

@AceTheCreator @thulieblack @Mayaleeeee Please take a look at this PR. Thanks! 👋

Mayaleeeee
Mayaleeeee approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@Mayaleeeee Mayaleeeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thank you @TenzDelek

@thulieblack
Copy link
Member

@AceTheCreator can you have a look here

AceTheCreator
AceTheCreator approved these changes Jun 19, 2024
View reviewed changes
Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AceTheCreator AceTheCreator merged commit 36b0535 into asyncapi:master Jun 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mayaleeeee Mayaleeeee Mayaleeeee approved these changes

@AceTheCreator AceTheCreator AceTheCreator approved these changes

@thulieblack thulieblack Awaiting requested review from thulieblack thulieblack is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] SubMenu of Venue not Closing when Click
5 participants
@TenzDelek @thulieblack @asyncapi-bot @AceTheCreator @Mayaleeeee