Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added financial sponsor logo #326

Merged
merged 7 commits into from
Jun 12, 2024
Merged

fix: added financial sponsor logo #326

merged 7 commits into from
Jun 12, 2024

Conversation

TenzDelek
Copy link
Contributor

Description
Added Financial sponsor (gravitee.io) logo
image

Related issue(s)
Fixes #324

Copy link

netlify bot commented Jun 7, 2024

Deploy Preview for peaceful-ramanujan-288045 ready!

Name Link
🔨 Latest commit b4ed2a9
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/6669540a14ca900008a5501f
😎 Deploy Preview https://deploy-preview-326--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@TenzDelek TenzDelek changed the title Fix: added financial sponsor logo fix: added financial sponsor logo Jun 7, 2024
@thulieblack
Copy link
Member

@TenzDelek can we follow the same font size for the Financial Sponsor same as Host Sponsors

image

And Also move the Host Sponsors heading to where I pointed

Copy link
Member

@thulieblack thulieblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use this logo instead let me see how it will look like

gravitee logo

@TenzDelek TenzDelek requested a review from thulieblack June 7, 2024 10:27
@thulieblack
Copy link
Member

/ptal

@asyncapi-bot
Copy link
Contributor

@AceTheCreator @Mayaleeeee Please take a look at this PR. Thanks! 👋

@AceTheCreator
Copy link
Member

@thulieblack did you get this image from Gravitee themselves?

@thulieblack
Copy link
Member

@AceTheCreator, the Gravitee logo I got is this one well, the one you see, I removed the white background to blend with the website design, but Im happy to revert it back

gravitee io_dark_blue_logo_720

Copy link
Member

@Mayaleeeee Mayaleeeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @TenzDelek
Thanks for working on this.

Please change the logo and grab another one with a transparent background from this link: https://www.gravitee.io/branding

cc @thulieblack @AceTheCreator

@TenzDelek
Copy link
Contributor Author

Hello @TenzDelek Thanks for working on this.

Please change the logo and grab another one with a transparent background from this link: https://www.gravitee.io/branding

cc @thulieblack @AceTheCreator

have added logo from the official page
c @Mayaleeeee @AceTheCreator @thulieblack

@Mayaleeeee
Copy link
Member

Hello @TenzDelek Thanks for working on this.

Please change the logo and grab another one with a transparent background from this link: https://www.gravitee.io/branding

cc @thulieblack @AceTheCreator

have added logo from the official page
c @Mayaleeeee @AceTheCreator @thulieblack

It looks good; it's just a tiny thing to do.
Reduce its size to be of the same size as the 'Apidays' logo.

@TenzDelek TenzDelek requested a review from Mayaleeeee June 9, 2024 06:48
@thulieblack
Copy link
Member

Looks great,

@Mayaleeeee , @AceTheCreator please approve so we can get this merged

Copy link
Member

@Mayaleeeee Mayaleeeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, @TenzDelek

@AceTheCreator
Copy link
Member

@thulieblack is Gravitee a financial sponsor for all the conferences?

@thulieblack
Copy link
Member

yes @AceTheCreator

@thulieblack
Copy link
Member

/ptal

@asyncapi-bot
Copy link
Contributor

@AceTheCreator Please take a look at this PR. Thanks! 👋

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@AceTheCreator AceTheCreator merged commit c09d413 into asyncapi:master Jun 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Gravitee Logo as Financial Sponsor
5 participants