-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: resources added for Helsinki #327
Conversation
✅ Deploy Preview for peaceful-ramanujan-288045 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@TenzDelek, why not replicate what we did last year and something similar to this |
@thulieblack sure, will implement that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
➕1 on the suggestion Thulie made about the resources.
Have made the changes as per @thulieblack said 😀 |
Hey @TenzDelek can you make it centered does not look good when there is just one element in the drop down. |
Sure, have my nimcet exam today, will start the changes from tomorrow 👍 |
@ashmit-coder have done the centering :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/ptal |
@AceTheCreator Please take a look at this PR. Thanks! 👋 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TenzDelek i think you should take a look at the alignment on the venue menu, you've probably messed with he alignment.
hmm.. interesting, the plan was to move the items to the center as it doesn't look great when there is only one item as suggested by @ashmit-coder . should i write a logic for it or make it back to default layout?? |
Yes, please |
yes for implementing a further function or making it back to default? :), from my perspective, i think reverting it back to the default sounds better as there will be further resources added in the near future. |
@TenzDelek whats the status here? |
…ebsite into fix/resourceadded
@thulieblack done :) |
you have some conflicts you need to resolve first |
@AceTheCreator check the changes |
@TenzDelek, i noticed a bug. when I hover on the resources tab, the venue dropdown gets activated. Can you look into that? |
@AceTheCreator this should fix it :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @TenzDelek the dropdown options have became unclickable, due to changes.
It has affected the venues section as well, ptal.
https://github.com/asyncapi/conference-website/assets/69006513/9d595844-a152-4b21-a2c6-40b4a6e73780 |
@TenzDelek can you look into rectifying the issue with your PR? |
@ashmit-coder @AceTheCreator Done with the Change :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!!
Description
resources added for Helsinki
Related issue(s)
Fixes #325