chore(dependencies): update nextjs to version 14 #335
Conversation
…pgrade nextjs, react and reactdom version
jerensl
requested review from
AceTheCreator,
thulieblack and
Mayaleeeee
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for peaceful-ramanujan-288045 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Hey @jerensl the changes look good to me. Have to tested for breaking in the website if any? |
I checked the staging preview and it looks fine to me, if you find any bug feel free to ping me again |
|
Hey @jerensl can you mention any resources you followed. The site does not seem to have bugs either |
| @@ -5,9 +5,9 @@ | |||
| "scripts": { | |||
| "dev": "next dev", | |||
| "build": "next build", | |||
| "start": "next start", | |||
| "start": "npx serve ./out/", | |||
There was a problem hiding this comment.
Why wont next start work over here?
There was a problem hiding this comment.
Is this project using server-side rendering which requires a server to run?
My approach above is for serving static site generators
There was a problem hiding this comment.
In my opinion let's just have next start cause the website is not entirely static / server side rendered
There was a problem hiding this comment.
After did the changes I will rollback to use export again after it breaks the staging build, looks like Netlify has its command for serving the website as referred to in the image below
There was a problem hiding this comment.
I see let's get @AceTheCreator opinion on this. Cause I don't have access to netlify
There was a problem hiding this comment.
Hey @jerensl
have a look at the Netlify.toml, the Node version is not as said and you can change the build and deploy command from there I guess.
So look into it :)
@ashmit-coder I mean this one, if I'm not mistaken this is staging website generated by netlify right? |
That's not my question but no worries. |
|
@ashmit-coder @jerensl I don't really understand y'all argument. Do you mind making it more understandable? |
I dont think we had proper communication over it, I will talk to @jerensl for now and let you know soon! |
Let me clarify, as I understand there are 2 ways to deploy a web app:
Most of the CDN services like Netlify etc, it will be running the That's why I and @ashmit-coder have a different opinion on |
|
After making changes as requested, I decided not to continue this work anymore because don't have the bandwidth to deal with that now thanks. Anyone can take this issue from now |
Description
This upgrade required changing the nvmrc to use nvm 18>, because NextJS 14 not supporting node below version 18.
I'm also updating ReactJS and ReactDOM to the latest version to support NextJS 14
Related issue(s)
Resolves #333