Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add 'Buy Tickets' button and improve 'Get Tickets' section design #514

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

IVedantD
Copy link

@IVedantD IVedantD commented Jan 10, 2025

What does this PR do?

This PR introduces the following changes:

  • Adds a new "Buy Tickets" button for better functionality and user interaction.
  • Resolves the alignment and design issues in the "Get Tickets" section.
  • Improves visual hierarchy, spacing, and layout for a modern and responsive design.

How It Was Tested

  • Tested on Mozilla Firefox to ensure proper alignment and design.
  • Checked responsiveness on various screen sizes.

Screenshots

Before:

Screenshot 2025-01-10 151222

After:

Screenshot 2025-01-10 151405

Linked Issue

Fixes #500

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

netlify bot commented Jan 10, 2025

Deploy Preview for peaceful-ramanujan-288045 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 7c2c17e
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/678a26854c7f8d000834f1a4
😎 Deploy Preview https://deploy-preview-514--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@IVedantD IVedantD changed the title Fix: Align 'Get Tickets' Section, Improve Design, and Add 'Buy Tickets' Button Feat: Align 'Get Tickets' Section, Improve Design, and Add 'Buy Tickets' Button Jan 10, 2025
@IVedantD IVedantD changed the title Feat: Align 'Get Tickets' Section, Improve Design, and Add 'Buy Tickets' Button feat: Add 'Buy Tickets' Button and Improve 'Get Tickets' Section Design Jan 10, 2025
@IVedantD IVedantD changed the title feat: Add 'Buy Tickets' Button and Improve 'Get Tickets' Section Design feat: add 'Buy Tickets' button and improve 'Get Tickets' section design Jan 10, 2025
@ashmit-coder
Copy link
Collaborator

Hey @thulieblack could you please guide @IVedantD to where the button should redirect to?

@IVedantD
Copy link
Author

Thank you for pointing this out ! @thulieblack could you please tell me where the button should redirect? i would be glad to make the required adjustments.

@thulieblack
Copy link
Member

there shouldn't be a button there, @ashmit-coder; the ticket cards show up when we do conference registrations and when purchasing tickets. It is something that is activated according to locations

@IVedantD
Copy link
Author

Okay @thulieblack I'll remove the "Buy Tickets" button and focus on aligning the text to resolve the design and alignment issues. Let me know if there's anything else you'd like me to adjust!

@IVedantD
Copy link
Author

@thulieblack I’ve made the requested changes:

Removed the "Buy Tickets" button.
Fixed the alignment of the "Get Tickets and Text " section as per the feedback. Please review and let me know if further adjustments are needed. Thank you!

@ashmit-coder
Copy link
Collaborator

hey @IVedantD the buy ticket button is still there.

@ashmit-coder
Copy link
Collaborator

you have not pushed your changes IMO.

@IVedantD
Copy link
Author

Hey @ashmit-coder I’ll double-check and push the changes right away. Sorry for the confusion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Misalignment and Ambigous Design in "Get Tickets" Section
3 participants