-
-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add 'Buy Tickets' button and improve 'Get Tickets' section design #514
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
✅ Deploy Preview for peaceful-ramanujan-288045 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hey @thulieblack could you please guide @IVedantD to where the button should redirect to? |
Thank you for pointing this out ! @thulieblack could you please tell me where the button should redirect? i would be glad to make the required adjustments. |
there shouldn't be a button there, @ashmit-coder; the ticket cards show up when we do conference registrations and when purchasing tickets. It is something that is activated according to locations |
Okay @thulieblack I'll remove the "Buy Tickets" button and focus on aligning the text to resolve the design and alignment issues. Let me know if there's anything else you'd like me to adjust! |
@thulieblack I’ve made the requested changes: Removed the "Buy Tickets" button. |
hey @IVedantD the buy ticket button is still there. |
you have not pushed your changes IMO. |
Hey @ashmit-coder I’ll double-check and push the changes right away. Sorry for the confusion |
…tion as per feedback
…tD/conference-website into fix/get-tickets-alignment
What does this PR do?
This PR introduces the following changes:
How It Was Tested
Screenshots
Before:
After:
Linked Issue
Fixes #500