Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: introduce external link logo and some code cleanup #526

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

TenzDelek
Copy link
Contributor

Description

  • for the resource hub, all these links are taking us to external so having a visual for that would be very helpful for the user
  • also some code cleanup for unused items
image

Related issue(s)

fixes #525

Copy link

netlify bot commented Jan 17, 2025

Deploy Preview for peaceful-ramanujan-288045 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ae98117
🔍 Latest deploy log https://app.netlify.com/sites/peaceful-ramanujan-288045/deploys/679206e4e9e52a00084752fe
😎 Deploy Preview https://deploy-preview-526--peaceful-ramanujan-288045.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@AceTheCreator AceTheCreator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TenzDelek I think the code cleanup should come in a seperate PR, as there should always be seperation of concern

@TenzDelek
Copy link
Contributor Author

@TenzDelek I think the code cleanup should come in a seperate PR, as there should always be seperation of concern

sure, will raise a separate pr

This reverts commit e27f891.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] external link logo at resource hub and some code cleanup
2 participants