Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for AMQP 1.0 #258

Open
fmvilas opened this issue Feb 24, 2022 · 26 comments
Open

Add support for AMQP 1.0 #258

fmvilas opened this issue Feb 24, 2022 · 26 comments
Labels
enhancement New feature or request stale

Comments

@fmvilas
Copy link
Member

fmvilas commented Feb 24, 2022

Reason/Context

Currently, Glee only supports WebSockets (server) and MQTT protocols. This means it's unusable for those using Kafka, AMQP, or any other different protocol.

Description

We should add support for AMQP 1.0. In theory, it should be just a matter of adding a new adapter in the adapters folder. Beware AMQP 1.0 and AMQP 0-9-1 are totally different protocols, despite having the same name.

@fmvilas fmvilas added enhancement New feature or request gsoc This label shoudl be used for issues or discussions related to ideas for Google Summer of Code labels Feb 24, 2022
@atharvagadkari05
Copy link

@fmvilas I would like to work on this issue under the GSOC tag. I want to discuss some of the things which will just clarify my doubts even further.

@fmvilas
Copy link
Member Author

fmvilas commented Feb 28, 2022

Great! Yeah, feel free to ask any questions. I'm happy to answer them :)

@atharvagadkari05
Copy link

The adapter folder has two different files for ws and socket.io. Do we have to make two different files for AMQP and RabbitMQ for the integration?

@fmvilas
Copy link
Member Author

fmvilas commented Mar 3, 2022

No, since RabbitMQ uses AMQP 0-9-1, this is something to be implemented in #257.

@atharvagadkari05
Copy link

Great to be back at this issue. I've already started working on this issue.
Do I have to explain how I'm gonna execute this, here?
@fmvilas @derberg

@fmvilas
Copy link
Member Author

fmvilas commented May 2, 2022

No, you don't have to but feel free to share as much information as you want. Please, bear in mind we'll decide on the list of candidates by June 6th so I would not work on this in the meantime.

@atharvagadkari05
Copy link

atharvagadkari05 commented May 23, 2022

Hey there 👋 hope everyone's doing great. I was a little bit inactive due to my exams.
It is just a quick update on the things I'm working on.

  1. Azure Service Bus and its functions.
  2. How does this service use functionalities of AMQP.
  3. How the Integration works internally and its requirements.

Is there anything more I can do then please let me know.

@fmvilas @magicmatatjahu @derberg

@atharvagadkari05
Copy link

@fmvilas Is this issue still open for work?
I was unable to make it through the mentorship program can I still work on this issue???

@fmvilas
Copy link
Member Author

fmvilas commented Jul 18, 2022

Absolutely 👍 Would be awesome, actually :)

@atharvagadkari05
Copy link

I'm kinda stuck on this issue, don't know where to start. Can anyone guide me for the same?

@fmvilas
Copy link
Member Author

fmvilas commented Jul 29, 2022

@atharvagadkari05 I'm happy to guide you. I'll ping you after August 15th, I'm going on holiday now.

@fmvilas
Copy link
Member Author

fmvilas commented Aug 22, 2022

I'm back now, @atharvagadkari05. How can I help you? Where are you stuck? Would be awesome if you can share some code (if you have it) or provide a detailed explanation of why/where are you stuck. Happy to jump on a call if needed.

@atharvagadkari05
Copy link

Thanks for the reply @fmvilas 👍. I haven't written any code, I was just reading about different protocols (AMQP and its versions).
As you mentioned I checked the adapter folder and different files (MQTT and socketio). I just need to know where I can start and what to do further. It would be fantastic if you could guide me to some sources(Blogs, Docs).

Once I know what to do I can proceed with my work 👍.

@fmvilas
Copy link
Member Author

fmvilas commented Aug 28, 2022

@atharvagadkari05 I'm doing a Glee codebase onboarding session tomorrow at 4 PM CEST. Do you want to join?

@atharvagadkari05
Copy link

@fmvilas Sure 👍

@atharvagadkari05
Copy link

@Souvikns @fmvilas I think I've found the official documentation for the AMQP JavaScript client (Rhea)
https://access.redhat.com/documentation/en-us/red_hat_amq/7.0/html-single/using_the_amq_javascript_client/index
Can you please confirm?
Also, I'm planning to open a draft PR so that you can track my progress.

@fmvilas
Copy link
Member Author

fmvilas commented Oct 18, 2022

This is not the official rhea docs AFAIK. This is just an RH library making use of rhea if I understood correctly.

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Feb 16, 2023
@kaushik-rishi
Copy link
Contributor

I'm picking this up with @KhudaDad414 permission.

@AceTheCreator
Copy link
Member

I'm picking this up with @KhudaDad414 permission.

I don't think that will be necessary, as there's already a PR for it, #456

@KhudaDad414
Copy link
Member

@AceTheCreator amqp 0-9-1 and amqp 1 are two different protocols for some reason. 😆

@AceTheCreator
Copy link
Member

AceTheCreator commented Jun 14, 2023

I'm so sorry; I thought it was the same issue 😂

@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Oct 13, 2023
@KhudaDad414 KhudaDad414 removed stale gsoc This label shoudl be used for issues or discussions related to ideas for Google Summer of Code labels Nov 9, 2023
Copy link
Contributor

github-actions bot commented Mar 9, 2024

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@KhudaDad414
Copy link
Member

Still relevant.

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request stale
Projects
None yet
Development

No branches or pull requests

5 participants