Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing Java import for @Valid annotation #2179

Merged

Conversation

nagyesta
Copy link
Contributor

@nagyesta nagyesta commented Feb 8, 2025

Description

  • Add missing annotation
  • Update tests

Related Issue

#2175

Checklist

  • The code follows the project's coding standards and is properly linted (npm run lint).
  • Tests have been added or updated to cover the changes.
  • Documentation has been updated to reflect the changes.
  • All tests pass successfully locally.(npm run test).

Additional Notes

Sorry, just noticed that I have missed to add the import in #2176 (made with my work account).

- Add missing annotation
- Update tests

Resolves asyncapi#2175

Signed-off-by: Esta Nagy <nagyesta@gmail.com>
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link

netlify bot commented Feb 8, 2025

Deploy Preview for modelina canceled.

Name Link
🔨 Latest commit 33752cf
🔍 Latest deploy log https://app.netlify.com/sites/modelina/deploys/67a7c19522fc840008469fed

Copy link

sonarqubecloud bot commented Feb 8, 2025

Copy link
Member

@jonaslagoni jonaslagoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time @nagyesta 🙏

@jonaslagoni
Copy link
Member

/rtm

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13219121504

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 92.403%

Totals Coverage Status
Change from base Build 13214456494: 0.001%
Covered Lines: 6476
Relevant Lines: 6871

💛 - Coveralls

@asyncapi-bot asyncapi-bot merged commit e0741dd into asyncapi:master Feb 9, 2025
26 checks passed
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 4.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@istvan-nagy-epam
Copy link
Contributor

Thank you for the quick merges @jonaslagoni !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants