Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include contributions from recent fork #7

Open
klamann opened this issue Oct 16, 2020 · 3 comments
Open

Include contributions from recent fork #7

klamann opened this issue Oct 16, 2020 · 3 comments
Assignees

Comments

@klamann
Copy link
Contributor

klamann commented Oct 16, 2020

Hi @philipflohr, I noticed your fork at philipflohr/personio-py, great stuff!

Would you like to open a PR so we can include your changes in the main repo and publish them on PyPI?

@klamann klamann self-assigned this Oct 16, 2020
@philipflohr
Copy link
Contributor

Hi @klamann, sure that was my idea. Thanks for that api communication basics - this makes adding new functionality really easy.
I'm not yet finished with my work as I'll need all the functions offered by the personio api - there are still some functions missing. Let's discuss the details in the PR.

@philipflohr
Copy link
Contributor

Hi @klamann.
I'll split the code changes into smaller chunks in separate PRs.
The most basic changes are in the PR #9 , #10 and #11

Once these are merged I can provide tho code changes from #8 in logically separated PRs (implementation and tests of absences and attendances together).

@klamann
Copy link
Contributor Author

klamann commented Nov 24, 2020

awesome, I'll look into those!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants