Merge pull request #94 from atc-net/hotfix/WellKnownColorSelector-random-color

fix: WellKnownColorSelector selected the wrong

Author: davidkallesen

sample/Atc.Wpf.Sample/SamplesWpfTheming/InputSelector/WellKnownColorSelectorView.xaml

@@ -35,6 +35,8 @@
 
                         <atc:WellKnownColorSelector DropDownFirstItemType="PleaseSelect" UseOnlyBasicColors="True" />
 
+                        <atc:WellKnownColorSelector SelectedKey="LightBlue" />
+
                     </atc:UniformSpacingPanel>
                     <atc:UniformSpacingPanel
                         Grid.Column="2"

src/Atc.Wpf.Theming/Controls/Selectors/WellKnownColorSelector.xaml.cs

@@ -171,6 +171,8 @@ private void PopulateData(
 
         Items.AddRange(list.OrderBy(x => x.DisplayName, StringComparer.Ordinal));
 
+        UpdateTranslationForSelectedItem();
+
         if (setSelected)
         {
             if (string.IsNullOrEmpty(SelectedKey))
@@ -192,8 +194,6 @@ private IEnumerable<string> GetColorNames()
 
     private void SetSelectedIndexBySelectedKey()
     {
-        UpdateTranslationForSelectedItem();
-
         if (CbColors.SelectedValue is null)
         {
             return;
@@ -205,10 +205,13 @@ private void SetSelectedIndexBySelectedKey()
             if (CbColors.Items[i] is ColorItem item &&
                 item.Name == selectedValue)
             {
-                CbColors.SelectedIndex = i;
-                if (!processingUiCultureChanged)
+                if (CbColors.SelectedIndex != i)
                 {
-                    OnSelectionChanged(this, item);
+                    CbColors.SelectedIndex = i;
+                    if (!processingUiCultureChanged)
+                    {
+                        OnSelectionChanged(this, item);
+                    }
                 }
 
                 break;
@@ -220,6 +223,8 @@ private void UpdateTranslationForSelectedItem()
     {
         if (CbColors.SelectedIndex != -1)
         {
+            processingUiCultureChanged = true;
+
             var backupIndex = CbColors.SelectedIndex;
             if (CbColors.Items.Count > backupIndex + 1)
             {
@@ -231,6 +236,8 @@ private void UpdateTranslationForSelectedItem()
             }
 
             CbColors.SelectedIndex = backupIndex;
+
+            processingUiCultureChanged = false;
         }
     }