Separated Time unit into TimeDelta and TimeStamp
#243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addition and subtruction between `Timestamp`s is not allowed, but any other `Unit` operation/comparison is. `TimeDelta`s can be added/subtructed to/form `Timestamp`s. Deserialization of `Timestamp`: - `Number` -> interpreted as millis from Epoch - `Instant` (string representation) -> converted to Timestamp - `Duration` (string representation) -> interpreted as duration since Epoch (warn msg is logged) Deserialization of `TimeDelta` is the same as `Time` was before, with the diference that when an `Instant` is converted to an timedelta since Epoch a warning message is logged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Separated
Timeunit intoTimeDeltaandTimeStamp.Implementation Notes ⚒️
Addition and subtruction between
Timestamps is not allowed, but anyother
Unitoperation/comparison is.TimeDeltas can beadded/subtructed to/form
Timestamps.Deserialization of
Timestamp:Number-> interpreted as millis from EpochInstant(string representation) -> converted to TimestampDuration(string representation) -> interpreted as duration sinceEpoch (warn msg is logged)
Deserialization of
TimeDeltais the same asTimewas before, with thedifference that when an
Instantis converted to a timedelta since Epocha warning message is logged.
External Dependencies 🍀
N/A
Breaking API Changes⚠️
N/A