From 96f82b54bee1ffd39471e60382805d4c550678f1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Peter=20K=C3=B6rner?= Date: Thu, 20 Jul 2023 17:39:38 +0200 Subject: [PATCH] confluence: correctly report a failed pdf-export, even when the error occurs <100% --- atlassian/confluence.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/atlassian/confluence.py b/atlassian/confluence.py index 0423690a9..e0fbf7bd6 100644 --- a/atlassian/confluence.py +++ b/atlassian/confluence.py @@ -2723,12 +2723,12 @@ def get_pdf_download_url_for_confluence_cloud(self, url): progress_response = self.get(poll_url) percentage_complete = int(progress_response.get("progress", 0)) task_state = progress_response.get("state") - if percentage_complete == 100: + if task_state == "FAILED": + log.error("PDF conversion not successful.") + return None + elif percentage_complete == 100: running_task = False log.info("Task completed - {task_state}".format(task_state=task_state)) - if task_state == "FAILED": - log.error("PDF conversion not successful.") - return None log.debug("Extract task results to download PDF.") task_result_url = progress_response.get("result") else: