Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Demo only in HTTP #5

Open
valerio-bozzolan opened this issue Feb 14, 2022 · 2 comments
Open

Demo only in HTTP #5

valerio-bozzolan opened this issue Feb 14, 2022 · 2 comments

Comments

@valerio-bozzolan
Copy link

Hi all! I've noticed that the demo does not support HTTPs:

Here how I see it:

Screenshot_2022_02_14_125718

Are you aware of that? :)

Thank you so much for your work. I've discovered it from this list:

https://leafletjs.com/plugins.html

@atlefren
Copy link
Owner

Hi, thanks for noticing!

To be honest I haven't been looking at this code for several years. but a quick glance at the gh-pages branch (https://github.com/atlefren/storymap/blob/gh-pages/index.html) tells me that the problem probably is that I reference

<script src="http://cdnjs.cloudflare.com/ajax/libs/underscore.js/1.6.0/underscore-min.js"></script>
<script src="http://cdn.leafletjs.com/leaflet-0.7.2/leaflet.js"></script>

Which won't be loaded on https.

I am not aware of any CDNs hosting leaflet on https, but If you want to investigate this PRs are welcome!

@valerio-bozzolan
Copy link
Author

valerio-bozzolan commented Feb 17, 2022

Awwwwww yeah I know this answer! Here it is my friend:

https://unpkg.com/leaflet@0.7.2/dist/leaflet.js

https://unpkg.com/leaflet@0.7.2/dist/leaflet.css

I've stealed it somewhere from the Leaflet documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants