Wrong highlight for a property name

[KSXGitHub]

I just updated the lastest version of language-javascript (v0.112.0) which has the following bugs. I don't know which old version I used but it hasn't these bugs. Also, I think property names should be highlighted (in JSON objects and ES6 classes), it would be a good way to avoid these bugs.

I can use a keyword as a property name in JavaScript, but language-javascript matchs it wrong

test1 = {
    normal: "It's okay",
    function: "'function' is just a property name, and it's valid, please don't highlight this 'function' here"
}

class test2 {
    normal() {/* It's okay */}
    function() {/* Again, this 'function' is just a property name, not a keyword */}
}

test3 = {
    normal() {/* It's okay */},
    function() {/* This 'function' is a property name, not a keyword */}
}

[winstliu]

Also, I think property names should be highlighted (in JSON objects and ES6 classes), it would be a good way to avoid these bugs.

We're working on this - see #307.

[KSXGitHub]

@50Wliu Thank you, it's a good way to solve the first bug.

[adamreisnz]

Fwiw, the same happens for default as a property name:

[doughsay]

I'd like to throw in another example if it helps. This one's a little more complicated though, since it breaks the highlighting completely:

// highlights the contents of the string correctly as a string:
{ func: 'function foo() { return "foo"; }' };
"things are ok";

// now it thinks the string contents are actually a function definition:
{ function: 'function foo() { return "foo"; }' };
"not ok... :("

I filed this in linguist here: github-linguist/linguist#3003; they sent me here.