Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Links not in syntax #677

Open
icecream17 opened this issue Jun 29, 2020 · 1 comment
Open

Links not in syntax #677

icecream17 opened this issue Jun 29, 2020 · 1 comment

Comments

@icecream17
Copy link
Contributor

Summary

Hyperlinks are not detected unless "Use Tree Sitter Parsers" is unchecked.
This further means they don't have any syntax styles applied, like underlining.

Motivation

I'd like for links to be indicated in some way - only because it looks nice and stuff.

Examples
Within a string:
image

Within a comment:
image

Without the feature:
image
image

Describe alternatives you've considered

I don't think I can edit the javascript grammar itself to detect this within atom, though maybe i'm wrong.
Also, I don't want to uncheck "Use Tree Sitter Parsers" because the highlighting is mostly much better when it's checked.

Additional context

The "Use Tree Sitter Parsers" option is in Settings > Core > Scroll down

Also, when it's detected the class is "syntax--markup syntax--underline syntax--link syntax--https syntax--hyperlink"

@icecream17
Copy link
Contributor Author

icecream17 commented May 18, 2021

Note: this issue could be worked on, but it's unlikely to be resolved since tree-sitter grammars depend on tree-sitter parsers.

The "easiest way" to resolve this is for the parsers to already have unneccessary support for links which won't happen
So the only fix is using regexes to search for links in literal text (or whatever it's called)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant