Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore (c sshnpd): remove background thread in favor of synchronous job queuing #1605

Open
XavierChanth opened this issue Dec 9, 2024 · 1 comment
Assignees

Comments

@XavierChanth
Copy link
Member

XavierChanth commented Dec 9, 2024

Original ticket contents:

chore (c sshnpd): use pthread clean up functions to handle memory management on threads

https://man7.org/linux/man-pages/man3/pthread_cleanup_push.3.html

New contents:

The purpose of this ticket has changed, as the simpler option is to remove multi-threading entirely. The second thread in c sshnpd only runs a periodic job to refresh device info parameters. In order to keep things efficient, this means managing semaphores around the atclient and risking deadlocks.

Once policy has been introduced to c sshnpd, I expect that the median number of device_info entries to refresh with either be 0 or 1. Thus the job can be done synchronously since it will be very quick.

@XavierChanth XavierChanth self-assigned this Dec 9, 2024
@XavierChanth XavierChanth changed the title chore (c sshnpd): use pthread clean up functions to handle memory management on threads chore (c sshnpd): remove background thread in favor of synchronous job queuing Jan 6, 2025
@XavierChanth
Copy link
Member Author

XavierChanth commented Jan 20, 2025

Putting this in the backlog, we need to do this, but not until we are ready to implement RPC, and we won't be ready for another 1-2 sprints.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant